Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force sync registrations on --force-events flag #64

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Conversation

sangeetha5491
Copy link
Contributor

@sangeetha5491 sangeetha5491 commented Jul 13, 2023

Description

The PR contains the following changes:

Since aio app use is a pre-requisite for deploying registrations and may not always be executed by the user, this PR removes this dependency by making a call to IO events to always fetch the registrations in the workspace before updating them.

--force-events flag if true, will result in deletion of registrations that are part of the app.config.yaml file but not part of the Console workspace.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sangeetha5491 sangeetha5491 marked this pull request as draft July 13, 2023 18:29
@sangeetha5491 sangeetha5491 changed the title Force sync registrations on --force-events flag and implementation on undeploy hooks [WIP] Force sync registrations on --force-events flag and implementation of undeploy hooks Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #64 (e89ca41) into master (b63559b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          596       611   +15     
  Branches        82        82           
=========================================
+ Hits           596       611   +15     
Impacted Files Coverage Δ
src/hooks/post-deploy-event-reg.js 100.00% <100.00%> (ø)
src/hooks/utils/hook-utils.js 100.00% <100.00%> (ø)
test/mocks.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sangeetha5491 sangeetha5491 changed the title [WIP] Force sync registrations on --force-events flag and implementation of undeploy hooks [WIP] Force sync registrations on --force-events flag Jul 13, 2023
@sangeetha5491 sangeetha5491 marked this pull request as ready for review July 13, 2023 19:46
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, makes sense to use the events API directly.

@sangeetha5491 sangeetha5491 changed the title [WIP] Force sync registrations on --force-events flag Force sync registrations on --force-events flag Jul 14, 2023
@sangeetha5491 sangeetha5491 merged commit 32d36ed into master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants