Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assets-11322. add aio-cli console support for public key rotation #173

Merged
merged 8 commits into from
Jun 15, 2022

Conversation

adamcin
Copy link
Contributor

@adamcin adamcin commented Jun 2, 2022

Description

Adds a group of commands to aio console:

aio console:publickey
aio console:publickey:list
aio console:publickey:upload FILE
aio console:publickey:delete IDORFINGERPRINT

Related Issue

https://jira.corp.adobe.com/browse/ASSETS-11322

Blocked by

adobe/aio-cli-lib-console#44

https://jira.corp.adobe.com/browse/IOC-4292

adobe/aio-lib-console#33

Motivation and Context

aio console should support workspace public key rotation, in combination with aio certificate:generate.

How Has This Been Tested?

Tested locally with npm linked branches of:

@adobe/aio-lib-console
@adobe/aio-cli-lib-console
@adobe/aio-cli-plugin-console

image

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #173 (128f972) into master (31fe67f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #173    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           14        18     +4     
  Lines          357       524   +167     
  Branches        42        75    +33     
==========================================
+ Hits           357       524   +167     
Impacted Files Coverage Δ
src/commands/console/publickey/delete.js 100.00% <100.00%> (ø)
src/commands/console/publickey/index.js 100.00% <100.00%> (ø)
src/commands/console/publickey/list.js 100.00% <100.00%> (ø)
src/commands/console/publickey/upload.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fe67f...128f972. Read the comment docs.

@purplecabbage purplecabbage merged commit aae28ca into adobe:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants