Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ioc-4292. correct issues with entp bindings in console api spec #33

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix: ioc-4292. correct issues with entp bindings in console api spec #33

merged 2 commits into from
Jun 9, 2022

Conversation

adamcin
Copy link
Contributor

@adamcin adamcin commented Jun 2, 2022 •
edited
Loading

Description

  • Corrected Enterprise Integrations binding endpoints for POST (uploadAndBind), GET, and DELETE (binding)
  • Corrected requestBody schema in api spec for POST (uploadAndBind)

Related Issue

https://jira.corp.adobe.com/browse/IOC-4292

Motivation and Context

CoreConsoleAPISDK fails with 404 when calling uploadAndBindCertificate (and getBindingsForIntegration), which is mapped to a Swagger API call for:

Organizations.post_console_organizations__orgId__integrations__intId__bindings

Error: [CoreConsoleAPISDK:ERROR_UPLOAD_AND_BIND_CERTIFICATE] 404 - Not Found ("<html> <head><title>404 Not Found</title></head> <body> <center><h1>404 Not Found</h1></center> <hr><center>openresty</center> </body> </html>")

How Has This Been Tested?

Tested locally with npm linked branches of:

@adobe/aio-lib-console
@adobe/aio-cli-lib-console
@adobe/aio-cli-plugin-console

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #33 (5741553) into master (0db9ac9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          477       477           
  Branches        15        15           
=========================================
  Hits           477       477
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db9ac9...5741553. Read the comment docs.

This was referenced Jun 2, 2022
Merged
Merged
Merged
@purplecabbage purplecabbage merged commit bea128f into adobe:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamcin @purplecabbage