TNT-48367 Make SPA view names lowercase (#1027)

* TNT-48367 Make SPA view names lowercase
adobe · Sep 13, 2023 · 3fbc4d9 · 3fbc4d9
1 parent e1105f1
commit 3fbc4d9
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 15 deletions.
diff --git a/src/components/Personalization/createOnClickHandler.js b/src/components/Personalization/createOnClickHandler.js
@@ -10,7 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
-import { isNonEmptyArray } from "../../utils";
+import { isNonEmptyArray, isNonEmptyString } from "../../utils";
 import { INTERACT } from "./constants/eventType";
 import { PropositionEventType } from "./constants/propositionEventType";
 import PAGE_WIDE_SCOPE from "../../constants/pageWideScope";
@@ -35,10 +35,10 @@ export default ({
         const xdm = { eventType: INTERACT };
         const scope = decisionsMeta[0].scope;
 
-        if (scope !== PAGE_WIDE_SCOPE) {
+        if (isNonEmptyString(scope) && scope !== PAGE_WIDE_SCOPE) {
           xdm.web = {
             webPageDetails: {
-              viewName: scope
+              viewName: scope.toLowerCase()
             }
           };
         }

diff --git a/src/components/Personalization/groupDecisions.js b/src/components/Personalization/groupDecisions.js
@@ -10,7 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
-import { isNonEmptyArray, includes } from "../../utils";
+import { isNonEmptyArray, includes, assign } from "../../utils";
 import isPageWideScope from "./utils/isPageWideScope";
 import {
   DOM_ACTION,
@@ -74,11 +74,16 @@ const splitDecisions = (decisions, ...schemas) => {
   return { matchedDecisions, unmatchedDecisions };
 };
 
-const appendScopeDecision = (scopeDecisions, decision) => {
-  if (!scopeDecisions[decision.scope]) {
-    scopeDecisions[decision.scope] = [];
+const appendViewScopeDecision = (scopeDecisions, decision) => {
+  if (!decision.scope) {
+    return;
   }
-  scopeDecisions[decision.scope].push(decision);
+  // Override view scope to lowercase to fix any casing issues
+  const viewDecision = assign({}, decision, { scope: decision.scope.toLowerCase() });
+  if (!scopeDecisions[viewDecision.scope]) {
+    scopeDecisions[viewDecision.scope] = [];
+  }
+  scopeDecisions[viewDecision.scope].push(viewDecision);
 };
 
 const isViewScope = scopeDetails =>
@@ -96,7 +101,7 @@ const extractDecisionsByScope = decisions => {
       if (isPageWideScope(decision.scope)) {
         pageWideScopeDecisions.push(decision);
       } else if (isViewScope(decision.scopeDetails)) {
-        appendScopeDecision(viewScopeDecisions, decision);
+        appendViewScopeDecision(viewScopeDecisions, decision);
       } else {
         nonPageWideScopeDecisions.push(decision);
       }

diff --git a/src/core/createEvent.js b/src/core/createEvent.js
@@ -115,11 +115,11 @@ export default () => {
       return shouldSendEvent;
     },
     getViewName() {
-      if (!userXdm || !userXdm.web || !userXdm.web.webPageDetails) {
+      if (!userXdm || !userXdm.web || !userXdm.web.webPageDetails || !userXdm.web.webPageDetails.viewName) {
         return undefined;
       }
 
-      return userXdm.web.webPageDetails.viewName;
+      return userXdm.web.webPageDetails.viewName.toLowerCase();
     },
     toJSON() {
       if (!isFinalized) {

diff --git a/test/functional/specs/Personalization/C6364798.js b/test/functional/specs/Personalization/C6364798.js
@@ -224,7 +224,7 @@ const simulateViewChangeForNonExistingView = async alloy => {
       eventType: "noviewoffers",
       web: {
         webPageDetails: {
-          viewName: "noView"
+          viewName: "noview"
         }
       }
     }
@@ -249,7 +249,7 @@ const simulateViewChangeForNonExistingView = async alloy => {
     .expect(
       noViewNotificationRequestBody.events[0].xdm.web.webPageDetails.viewName
     )
-    .eql("noView");
+    .eql("noview");
   await t
     // eslint-disable-next-line no-underscore-dangle
     .expect(noViewNotificationRequestBody.events[0].xdm._experience)

diff --git a/test/functional/specs/Personalization/C782718.js b/test/functional/specs/Personalization/C782718.js
@@ -221,7 +221,7 @@ const simulateViewChangeForNonExistingView = async alloy => {
       eventType: "noviewoffers",
       web: {
         webPageDetails: {
-          viewName: "noView"
+          viewName: "noview"
         }
       }
     }
@@ -246,7 +246,7 @@ const simulateViewChangeForNonExistingView = async alloy => {
     .expect(
       noViewNotificationRequestBody.events[0].xdm.web.webPageDetails.viewName
     )
-    .eql("noView");
+    .eql("noview");
   await t
     // eslint-disable-next-line no-underscore-dangle
     .expect(noViewNotificationRequestBody.events[0].xdm._experience)