Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where SPA view names were case-sensitive #1027

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

XDex
Copy link
Contributor

@XDex XDex commented Sep 5, 2023

Description

Considering we still have both internal and external customers running into SPA view case sensitivity issues, we need to fix this in Web SDK, so that for both Target and AJO, SPA view names are consistently lowercase across VEC, at.js and Web SDK.

Note: We're fixing this by setting the view name to lowercase both when using the viewName supplied under xdm.web.webPageDetails.viewName, as well as by lowercasing the view decision scopes (these are currently being lowercased at authoring time for TNT/AJO activities created in VEC UI, however in case any views were defined directly via TNT APIs these could still be case-sensitive)

Related Issue

https://jira.corp.adobe.com/browse/TNT-48367

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@XDex XDex requested review from ninaceban and jfkhoury September 5, 2023 16:24
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change affect ODE or AJO at all?

@XDex
Copy link
Contributor Author

XDex commented Sep 7, 2023

Will this change affect ODE or AJO at all?

@jonsnyder It will only fix AJO offers defined on SPA pages and won't affect ODE

@XDex XDex requested a review from carterworks September 12, 2023 11:23
@XDex XDex merged commit 3fbc4d9 into adobe:main Sep 13, 2023
@XDex XDex deleted the TNT-48367 branch September 13, 2023 08:41
@ninaceban
Copy link
Contributor

ninaceban commented Sep 19, 2023

@XDex thank you for working on the fix!
To avoid issues in our code we should follow best practices and keep things immutable whenever possible, especially the event.xdm object. Personalization SPA view logic should not affect Data Collection.

cc: @jfkhoury @jonsnyder @raresvla

@carterworks carterworks changed the title TNT-48367 Make SPA view names lowercase Fixed issue where SPA view names were case-sensitive Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants