Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move personalization flag to DecisioningEngine component #1075

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Move personalization flag to DecisioningEngine component #1075

merged 3 commits into from
Oct 31, 2023

Conversation

jonsnyder
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Oct 30, 2023
jasonwaters
jasonwaters reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@jasonwaters jasonwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to set the personalizationStorageEnabled flag to true in the InAppMessages.js sandbox demo page -- otherwise it'll be broken

jfkhoury
jfkhoury reviewed Oct 31, 2023
View reviewed changes
src/components/DecisioningEngine/index.js Outdated
@@ -117,4 +118,7 @@ const createDecisioningEngine = ({
};

createDecisioningEngine.namespace = "DecisioningEngine";
createDecisioningEngine.configValidators = objectOf({
personalizationStorageEnabled: boolean().default(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's default to false as agreed.

jfkhoury
jfkhoury reviewed Oct 31, 2023
View reviewed changes
test/functional/specs/LibraryInfo/C2589.js Outdated
@@ -60,7 +60,8 @@ test("C2589: getLibraryInfo command returns library information.", async () => {
onBeforeEventSend: "function func() {}",
orgId: "5BFE274A5F6980A50A495C08@AdobeOrg",
thirdPartyCookiesEnabled: true,
targetMigrationEnabled: false
targetMigrationEnabled: false,
personalizationStorageEnabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@jonsnyder jonsnyder merged commit 3fad398 into main Oct 31, 2023
@jonsnyder jonsnyder deleted the movePersonalizationFlag branch October 31, 2023 21:41
@jonsnyder jonsnyder mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfkhoury jfkhoury jfkhoury left review comments

@jasonwaters jasonwaters jasonwaters left review comments

@carterworks carterworks carterworks approved these changes

@shandilya3 shandilya3 shandilya3 approved these changes

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonsnyder @jasonwaters @jfkhoury @shandilya3 @carterworks