Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDCL-11254] limit personalization event storage to only AJO campaigns #1080

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[PDCL-11254] limit personalization event storage to only AJO campaigns #1080

merged 1 commit into from
Oct 31, 2023
+35 −1

Conversation

jasonwaters
Copy link
Collaborator

This PR changes the behavior of eventRegistry so that only experience edge events with a decisionProvider equal to AJO will be stored.

Related Jira: https://jira.corp.adobe.com/browse/PDCL-11254

@jasonwaters jasonwaters changed the title PDCL-11254 [PDCL-11254] limit personalization event storage to only AJO campaigns Oct 31, 2023
@jonsnyder jonsnyder mentioned this pull request Oct 31, 2023
Closed
7 tasks
jonsnyder
jonsnyder approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the storage option still defaults to true, but now only AJO events are stored there.

jfkhoury
jfkhoury requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's default to false as discussed, even though it's limited to AJO. Talked to Don and Mitch about this, and we will improve this logic/solution in the next couple of weeks.

@jonsnyder jonsnyder merged commit 3539519 into main Oct 31, 2023
@jonsnyder jonsnyder deleted the eventRegistryAJOOnly branch October 31, 2023 21:45
@jonsnyder
Copy link
Contributor

default to false added to #1075

@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfkhoury jfkhoury jfkhoury requested changes

@shandilya3 shandilya3 shandilya3 approved these changes

@jonsnyder jonsnyder jonsnyder approved these changes

@ninaceban ninaceban Awaiting requested review from ninaceban

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonwaters @jonsnyder @jfkhoury @shandilya3