-
Notifications
You must be signed in to change notification settings - Fork 613
Conversation
I am getting a build error on Mac OS X v10.6 due to the NSFileWriteFileExistsError flag is only available on OS X v10.7 and later. |
Thanks for reviewing! Are you using XCode 4.x? XCode 3.2.6 is no longer supported. I don't have a 10.6 system with me for testing, but this should be fine when running on a 10.6 system. If you try to rename an item to a name of an existing item, you will get a less friendly error message, but everything should work fine. |
I'll take on the mac side of the review. |
Windows looks good. Re-assigning to @jasonsanjose to take a look at Mac (since I need to upgrade to Xcode 4). |
NSString* pathStr = [NSString stringWithUTF8String:path.c_str()]; | ||
|
||
// TODO: honor mode | ||
[[NSFileManager defaultManager] createDirectoryAtPath:pathStr withIntermediateDirectories:FALSE attributes:nil error:&error]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed adobe/brackets#1759
Looks good. Merging |
Add fs.makedir() and fs.rename() APIs
Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.
Add fs.makedir() and fs.rename() APIs
Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.
Add two new functions to brackets.fs:
makedir()
rename()
BONUS FEATURES
This pull request also includes two small bonus features on the mac: