-
Notifications
You must be signed in to change notification settings - Fork 18
Enable Spanish updates and Sprint33 strings #86
Conversation
"newFeatures": [ | ||
{ | ||
"name": "Vista previa de imágenes", | ||
"description": "Seleccionar una imagen en el árbol de directorios muestra una vista previa de la misma." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use "Seleccionando" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then it should be: Seleccionando una imagen en el árbol... se muestra... Is that what you mean? What about Al seleccionar... se muestra... ? Which one do you prefer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preffer the second one.
@TomMalbran I've pushed a commit addressing your comments so far. I'm out for the weekend and won't be back until next week, so if you see anything else, just go ahead and fix it, please :) Also, since it's our first time around here, maybe we'd want to wait for @njx or @jasonsanjose to give us the good to go ;) |
Sure. Thanks for the fixes. And yes i'll wait to see what they have to say before merging. |
@jbalsas @TomMalbran Are you aware that once this es version is added to brackets-notifications, then it needs to be updated every sprint? If it's not updated in a future sprint then the downloads don't work. Just wanted to be sure you were aware of that. |
We shouldn't change |
@redmunds Yes, I realize that. But I think we can handle it, since is not that much to translate anyway. We could also fix this issue, by changing how the updates are fetched, or fetching both the English and the translated versions and use the one that fits, or by simply adding the English strings to every file and then translating it. @SAplayer I don't understand what you are saying. These are the update strings that appear in the Update Dialog in Brackets when there is a new Update. The problem we might have is that there might not be enough time to get the French and Japanese translations of this string change. |
@redmunds I actually didn't realize it until you pointed that out (although it was quite clear from the code...). However, if @TomMalbran is on board, I think we should be able to handle it together so that we don't stay behind. @SAplayer The Brackets spanish translation was indeed updated. See adobe/brackets#5676 ;) |
The current Sprint is about to be done, and we should merge this before that. The translations look good too. |
Merging. |
Enable Spanish updates and Sprint33 strings
@TomMalbran Care to review these?
@njx @jasonsanjose I've updated the
Updated Translations
message with Spanish since @TomMalbran just merged, and enabled the^es
rule to allow serving spanish updates. Could you check if everything is ok?