-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@@ -118,6 +118,7 @@ define({ | |||
"WITH" : "Con", | |||
"BUTTON_YES" : "Sí", | |||
"BUTTON_NO" : "No", | |||
"BUTTON_REPLACE_ALL" : "Todo\u2026", | |||
"BUTTON_ALL" : "Todos\u2026", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BUTTON_ALL was removed in the english strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow... that's weird... I must have copied that one before updating to master to do the work... I'll remove it
Done with the review. Did this included the Sprint 32 string updates? By the index, it seems like it does, but not sure if there were any string changes lately. |
Hey, @TomMalbran, I've pushed a commit with the discussed fixes. This should include all the string changes up to sprint 33, since I use the localization extension to compare the spanish locale with the root one ;) |
Great. Does that tool also checks for English string changes and not just additions and deletions? |
No, currently it just does static compare between the current state of the files but knows nothing about the history of the strings... that's a great idea worth exploring though ;) |
I was doing diff checks between the latest root string.js and the one at which the es strings was at. In this case the Sprint 32 strings: http://diffchecker.com/r3xa0z8u It seem like only LIVE_DEV_NEED_HTML_MESSAGE needs a string update. |
Updated and pushed. Good catch! (I'll see next week if I can use the git extension somehow to diff the changes in the root strings up to a point to detect these cases...) Also, I was thinking about translating brackets-update as well. Would you be up to review those as well starting next sprint? |
@@ -81,7 +81,7 @@ define({ | |||
"LIVE_DEVELOPMENT_RELAUNCH_TITLE" : "Conectando con el navegador", | |||
"LIVE_DEVELOPMENT_ERROR_MESSAGE" : "Para poder iniciar el modo de Desarrollo en Vivo, Chrome debe ser iniciado habilitando la depuración remota.<br /><br />¿Quieres reiniciar Chrome y habilitar la depuración remota?", | |||
"LIVE_DEV_LOADING_ERROR_MESSAGE" : "No se pudo cargar la página para Desarrollo en Vivo", | |||
"LIVE_DEV_NEED_HTML_MESSAGE" : "Abre un archivo HTML para poder iniciar el modo de Desarrollo en Vivo.", | |||
"LIVE_DEV_NEED_HTML_MESSAGE" : "Abre un archivo HTML o asegúrate de que hay un index.html en tu proyecto para poder iniciar el modo de Desarrollo en Vivo.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hay" -> "haya"
That would be great. And yes, I can review those too. Is it too late for this sprint? One final comment before ready to merge. |
Ok, I've forced pushed your last comment, so this should be good to go :) (I'll be sending you the brackets-updates translations for this sprint shortly) |
Great. Merging :) |
Spanish strings for Sprint 33
Updated spanish strings and getting started up to sprint 33.
@TomMalbran Care to review?