Skip to content

Commit

Permalink
fix(mwpw-138742): filter-params removed from url when group name has …
Browse files Browse the repository at this point in the history
…a space (#117)

* fix(mwpw-138742): filter-params removed from url when group name has a space

* fix(mwpw-138742): chromedriver

* fix(mwpw-138742): hopefully fixing packages lol

* fix(mwpw-138742): fixed maybe yay

* fix(mwpw-138742): replace globally in string

---------

Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
  • Loading branch information
sheridansunier and Sheridan Sunier authored Nov 29, 2023
1 parent af9d54c commit 8879177
Show file tree
Hide file tree
Showing 7 changed files with 39,538 additions and 4,441 deletions.
2 changes: 1 addition & 1 deletion dist/app.css

Large diffs are not rendered by default.

549 changes: 396 additions & 153 deletions dist/main.js

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions dist/main.min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/main.source.js

Large diffs are not rendered by default.

43,396 changes: 39,125 additions & 4,271 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"babel-preset-env": "^1.7.0",
"babel-preset-jest": "^22.4.4",
"babel-preset-react": "^6.24.1",
"chromedriver": "^117.0.0",
"chromedriver": "^119.0.0",
"commitizen": "^4.2.6",
"copy-webpack-plugin": "^4.6.0",
"cross-env": "^5.2.1",
Expand Down
6 changes: 3 additions & 3 deletions react/src/js/components/Consonant/Container/Container.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -440,11 +440,11 @@ const Container = (props) => {
clearUrlState();
// actually clear the url state
urlParams.forEach((value, key) => {
const chFilter = key.toLowerCase().replace('ch_', '').replace(' ', '-');
const chFilter = key.toLowerCase().replace('ch_', '').replace(/ /g, '-');
if (key.indexOf(filterGroupPrefix) !== 0
&& !id.toLowerCase().includes(chFilter)
|| !group.toLowerCase().includes(chFilter)) {
setUrlState(key, value.replace('%20', ' '));
|| !group.toLowerCase().replace(/ /g, '-').includes(chFilter)) {
setUrlState(key, value.replace(/%20/g, ' '));
}
});
};
Expand Down

0 comments on commit 8879177

Please sign in to comment.