fix(mwpw-138742): filter-params removed from url when group name has a space #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheridansunier
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sheridansunier
temporarily deployed
to
github-pages
GitHub Actions
Inactive
cmiqueo
requested changes
Nov 21, 2023
| @@ -443,7 +443,7 @@ const Container = (props) => { | |||
| const chFilter = key.toLowerCase().replace('ch_', '').replace(' ', '-'); | |||
| if (key.indexOf(filterGroupPrefix) !== 0 | |||
| && !id.toLowerCase().includes(chFilter) | |||
| || !group.toLowerCase().includes(chFilter)) { | |||
| || !group.toLowerCase().replace(' ', '-').includes(chFilter)) { | |||
There was a problem hiding this comment.
This will replace only the first space, you should use replaceAll(),
Try it in the console
'a b c d'.replace(' ', '-') vs. 'a b c d'.replaceAll(' ', '-')
sheridansunier
temporarily deployed
to
github-pages
GitHub Actions
Inactive
gmirijan
approved these changes
Nov 28, 2023
cmiqueo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter param is not removed from URL when filter cleared by clicking on the number next to the filter group when group name has a space.
This adds support for filter groups that have spaces (e.g. Content Type) as well as updates the chromedriver