MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … #537
Conversation
…DSET element - filter checkboxes
|
|
Skipped merging 537: MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … due to missing verified label. kindly make sure that the PR has been verified |
1 similar comment
|
Skipped merging 537: MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … due to missing verified label. kindly make sure that the PR has been verified |
…DSET element - filter checkboxes
|
Skipped merging 537: MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … due to missing verified label. kindly make sure that the PR has been verified |
| @@ -85,6 +103,7 @@ export default async function init(el) { | |||
| const sidenav = await initSidenav(sidenavEl); | |||
| el.prepend(sidenav); | |||
| await sidenav.updateComplete; | |||
| addCheckboxGroupAttributes(sidenav); | |||
There was a problem hiding this comment.
@bozojovicic
I think this should be addressed in milo at https://github.com/adobecom/milo/blob/stage/libs/features/mas/src/sidenav/merch-sidenav-checkbox-group.js
There was a problem hiding this comment.
Right. Agreed. And again, last week I tried to do that and I gave up and now I don't remember why. I created Milo PR for that adobecom/milo#3518 and it works quite nice. So closing this one.
|
Implemented in Milo adobecom/milo#3518 |
… element - filter checkboxes
A11Y fix - For Type Desktop/Mobile/Web checkbox group ARIA group/labelledby technique applied to announce the grouping as a part of the checkboxes. This does not work if we have
aria-labelledby="elementId"and#elementIdis in shadow DOM so I had to create new hidden DIV, outside shadow DOM, which will have that ID and contain the test "Types".Test page : /products/catalog
Resolves: MWPW-162026
Test URLs: