MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DSET element - filter checkboxes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3518 +/- ##
==========================================
- Coverage 96.47% 96.46% -0.02%
==========================================
Files 260 260
Lines 60415 60437 +22
==========================================
+ Hits 58284 58299 +15
- Misses 2131 2138 +7 ☔ View full report in Codecov by Sentry. |
npeltier
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… element - filter checkboxes
A11Y fix - In
merch-sidenav-checkbox-groupFor Type Desktop/Mobile/Web checkbox group ARIA group/labelledby technique applied to announce the grouping as a part of the checkboxes. This does not work if we have aria-labelledby="elementId" and #elementId is in shadow DOM so I had to create new hidden DIV, outside shadow DOM, which will have that ID and contain the text "Types".Test page : /products/catalog?milolibs=mwpw162026a11y--milo--bozojovicic
Resolves: MWPW-162026
Test URLs: