generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET … #3518
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b5a0584
MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIEL…
7a9cd52
Trigger Build
311f488
Trigger Build
b521112
MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIEL…
b5fd080
Merge branch 'stage' into mwpw162026a11y
9b2381b
Rebuild mas
775fded
Merge branch 'stage' into mwpw162026a11y
83887b8
Rebuild mas
b8541c7
MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIEL…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure i like the idea of merch-sidenav-checkbox-group being bound to sp-checkbox.
can't we add this 'role' attribute when we create those 'sp-checkboxes'? https://github.com/adobecom/cc/blob/stage/creativecloud/blocks/sidenav/sidenav.js#L79
I understand it means we need to rely on some stable id, so not sure if its better or not. maybe a bit less confusing for devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same with
groupIdEl
element, it could be probably created by sidenav block@npeltier @yesil wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the JIRA recommends a few options, but can we try the OOTB SWC approach with
sp-field-group
https://opensource.adobe.com/spectrum-web-components/components/field-group/
Before implementing this solution, the accessibility tool can be run against checkboxes in the SWC documentation
if it doesn't complain we can follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesil I tried your idea directly on catalog page
it doesn't work. :( Screen reader ignores the word "Types" although it is there twice, once in element "label" and once in attribute "label"
@3ch023 we had this in CC code before but then it was requested to move to Milo
@npeltier I can move that "types" element from shadow to light dom but again I need to iterate through checkboxes to set attributes 'aria-labelledby', and that is where Mariia complains about
So, option A : I do it in CC code in sidenav.js, I move the H3 element from shadow to light dom
option B : I do the same thing in milo code
For both options one reviewer will not be happy.
@3ch023 I could also try to iterate through direct children of
merch-sidenav-checkbox-group
, without bounding tosp-checkbox
, in that case it would be OK to do it in Milo code, right? I think that is the only solution where everyone is happy. Let me try.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with any solution you pick, its just the current one looked 'hacked' to me. and i wonder if there is a better way. (first sidenav block creates elements, then checkout-group modifies it's children and itself)
I've read @npeltier new suggestion a few times and didn't understand it still