Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC MILO Release 0.2450 #918

Merged
merged 3 commits into from
Dec 10, 2024
Merged

DC MILO Release 0.2450 #918

merged 3 commits into from
Dec 10, 2024

Conversation

joaquinrivero
Copy link
Collaborator

TsayAdobe and others added 3 commits December 6, 2024 12:17
* Reload page if going back forward

* Remove comment
* SUSI default using placeholders link for scenario when users use open in new (tab, window)

* Refactoring  SUSI Handler

---------

Co-authored-by: James Tsay <65299136+TsayAdobe@users.noreply.github.com>
Copy link

aem-code-sync bot commented Dec 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 10, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (8d62f2d) to head (847d448).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
acrobat/scripts/susiAuthHandler.js 0.00% 38 Missing ⚠️
acrobat/blocks/verb-widget/verb-widget.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   81.38%   81.02%   -0.36%     
==========================================
  Files          49       49              
  Lines        6424     6452      +28     
==========================================
  Hits         5228     5228              
- Misses       1196     1224      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquinrivero joaquinrivero merged commit 70160c2 into main Dec 10, 2024
105 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants