MWPW-163684 Set trial limit and show upsell #938
Conversation
TsayAdobe
requested review from
peller,
joaquinrivero,
saragajic11,
Ruchika4 and
sanjayms01
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #938 +/- ##
==========================================
- Coverage 80.60% 80.06% -0.55%
==========================================
Files 49 49
Lines 6513 6560 +47
==========================================
+ Hits 5250 5252 +2
- Misses 1263 1308 +45 ☔ View full report in Codecov by Sentry. |
| @@ -205,6 +236,14 @@ export default async function init(element) { | |||
| // Analytics | |||
| verbAnalytics('landing:shown', VERB); | |||
|
|
|||
| if (LIMITS[VERB].trial) { | |||
| const count = parseInt(localStorage.getItem(`${VERB}_trial`), 10); | |||
| if (count >= LIMITS[VERB].trial) { | |||
There was a problem hiding this comment.
If I'm understanding this correctly, this logic would show the upsell screen even on the 2nd attempt since it's using >=. Would trial need to be updated to 3 in the limits.js file?
There was a problem hiding this comment.
1st trial, count = NaN, after uploading, the local storage = 1.
2nd trial, count = 1, after uploading, the local storage = 2.
3rd attempt, count = 2, count >= LIMITS[VERB].trial
There was a problem hiding this comment.
Ah that makes sense, thanks for clarifying!
It's the first part of the story. Social CTA will be added later after SUSI light block is done.
Resolve: MWPW-163684
Test URLs
Before: https://www.stage.adobe.com/acrobat/online/test/compress-pdf.html
After: https://mwpw-163684--dc--adobecom.hlx.page/acrobat/online/test/compress-pdf?unitylibs=stage