Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-163684 Show Social CTA on Upsell #940

Merged
merged 5 commits into from
Jan 13, 2025
Merged

MWPW-163684 Show Social CTA on Upsell #940

merged 5 commits into from
Jan 13, 2025

Conversation

TsayAdobe
Copy link
Collaborator

It's the second part of the story. Use SUSI Light block for Social CTA. This PR includes changes from #938 and #939.

Resolve: MWPW-163684

Test URLs
Before: https://www.stage.adobe.com/acrobat/online/test/compress-pdf.html
After: https://mwpw-163684x--dc--adobecom.hlx.page/acrobat/online/test/compress-pdf?unitylibs=stage

Desktop
upsell_desktop

Mobile
upsell_mobile

Copy link

aem-code-sync bot commented Jan 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 10, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (stage@603ce4e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             stage     #940   +/-   ##
========================================
  Coverage         ?   78.53%           
========================================
  Files            ?       50           
  Lines            ?     6696           
  Branches         ?        0           
========================================
  Hits             ?     5259           
  Misses           ?     1437           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TsayAdobe TsayAdobe merged commit 26743f8 into stage Jan 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants