MWPW-153599: M@S Studio initial commit #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged
3ch023
reviewed
Jul 8, 2024
npeltier
approved these changes
Jul 8, 2024
| * @param {string} bucket | ||
| */ | ||
| constructor(bucket) { | ||
| if (!bucket) throw new Error('bucket is required'); // TODO provide better error message. |
| import { AEM } from '@adobe/mas-commons'; | ||
| import { Fragment } from './Fragment.js'; | ||
|
|
||
| let merchDataSourceCache; |
There was a problem hiding this comment.
I started with Datasource, then changed to DataSource :-/
|
|
||
| async doSearch(props) { | ||
| this.search.update(props); | ||
| const fragments = await this.aem.sites.cf.fragments |
There was a problem hiding this comment.
may be we should
- consider abstracting API from CF
- differentiate between name "fragments" that are HTML/WC hydrated with content from what this does which is merch content? merchContent? merchItem ?
There was a problem hiding this comment.
the lightweight AEM api is a mini client for https://developer.adobe.com/experience-cloud/experience-manager-apis/api/stable/sites/
Since we are operating in headless mode, fragment is by nature the data and not HTML/WC.
I think "merch card" as term is good enough, e.g: I'll other a merch card in MAS Studio.
mirafedas
approved these changes
Jul 8, 2024
yesil
changed the title
3ch023
approved these changes
Jul 8, 2024
yesil
added
do not merge
rohitsahu
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
On top of these, all the files in mas have been linted automatically.
imports have been re-adjusted.
Resolves: MWPW-153599
Test URLs: