-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-153658 audit script #25
Conversation
- parse one or several url or sitemap files (can be added in manifest), - for each url from sitemap, parse page for personnalization fragment or fragment, - for each ost link found in html, keep usage, - for each osi, get wcs entry, - output everything as CSV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good to me.
In #22, there is eslint/prettier lint rules. If possible I suggest to lint your code with it before the initial merge.
const prefixWcsKey = (key) => ('wcs ' + key); | ||
|
||
async function getCommerceData(osi) { | ||
const response = await fetch(wcsUrl(osi)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that okay if the OSI doesn't return an offer anymore via WCS? AOS can always deliver the parameters of an OSI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i prefer usage of WCS as blank answer there is also something we should be worried about
@@ -0,0 +1,186 @@ | |||
https://www.adobe.com/cc-shared/assets/sitemap.xml | |||
https://www.adobe.com/au/cc-shared/assets/sitemap.xml | |||
https://www.adobe.com/cn/cc-shared/assets/sitemap.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does the list of sitemaps coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i created it out of the locales we have in our code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably add a disclamer that these are not all Milo pages, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this manifest is here for somebody (me for now) to use. Nothing say this manifest is here to get everything :) (i wait for discussion with business for this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, although sitemaps list is missing homepage, but we can add it later
|
…into rosahu/MWPW-147172 * 'rosahu/MWPW-147172' of https://github.com/adobecom/mas: feat(MWPW-142267): Merch What's Included and Merch Mnemonic List (TwP) (#4) MWPW-153962: update /lib to /libs (#30) MWPW-153658 audit script (#25) MWPW-153962: support maslibs approach (#28)
Test URLs: