MWPW-153962: support maslibs approach #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yesil
changed the title
npeltier
approved these changes
Jul 9, 2024
3ch023
approved these changes
Jul 9, 2024
rohitsahu
pushed a commit
that referenced
this pull request
Jul 10, 2024
…into rosahu/MWPW-147172 * 'rosahu/MWPW-147172' of https://github.com/adobecom/mas: feat(MWPW-142267): Merch What's Included and Merch Mnemonic List (TwP) (#4) MWPW-153962: update /lib to /libs (#30) MWPW-153658 audit script (#25) MWPW-153962: support maslibs approach (#28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the http meta approach with search params in
mas.jsurl for passing the context.e.g:
the
features=merch-cardparameter is to support CCD/CCH use cases, and Milo will keep loading those dependencies separately.Resolves: MWPW-153962
Milo PR: adobecom/milo#2544
Test URLs: