Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-153599: M@S Studio solution design #36

Merged
merged 10 commits into from
Aug 1, 2024
Merged

MWPW-153599: M@S Studio solution design #36

merged 10 commits into from
Aug 1, 2024

Conversation

yesil
Copy link
Collaborator

@yesil yesil commented Jul 11, 2024

This PR provides the followings:

  • Basic live Merch card editing feature
  • Tinymce RTE integration
    • inline-price and checkout-link configurations to make them not editable (can be removed, added but not edited)
  • Classic Offer Selector integration(wip, double click a card, and hit the star button on the top left of the form)
  • Centralized internal(artifactory) dependencies to gain efficiency for the build of studio.

Configuration:

  1. open the after URL
  2. open https://experience.adobe.com/#/@odin02/aem/editor/canvas/mas--milo--adobecom.hlx.live/libs/features/mas/studio.html and copy the access token (contact @Axelcureno for help)
  3. set masAccessToken at the after URL(step 1)
  4. Refresh
  5. Type ccd-action in the search
  6. Double click on a card

Screenshots:

  1. Edit form
    image
  2. OST
    image

In the unit tests (no token is needed) you can see that inline and checkout links work in the RTE:

image

http://localhost:2023/test/studio.test.html?wtr-test-file=%2Ftest%2Fstudio.test.html%3Fwtr-manual-session%3Dtrue#path=%2Fcontent%2Fdam%2Fsandbox%2Fmas&query=ccd

The next step is to finish the integration with OST so that we can generate inline-price and checkout-link directly and put them in the RTE and save them to Odin.

Resolves: MWPW-153599

Test URLs:

Copy link

aem-code-sync bot commented Jul 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 11, 2024

Page Scores Audits Google
/studio.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@yesil yesil requested review from 3ch023, npeltier and Axelcureno July 12, 2024 15:22
@3ch023 3ch023 merged commit 4350874 into main Aug 1, 2024
4 of 5 checks passed
rohitsahu pushed a commit that referenced this pull request Aug 7, 2024
* 'ost' of https://github.com/adobecom/mas:
  Update mas.js
  Revert "resolved conflicts"
  Update mas.js
  updated deps
  MWPW-153599: M@S Studio solution design (#36)
  moved delay method
  Update package-lock.json
  Mwpw-151480: move of commerce and web components to milo (#49)
  [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (#45)
  MWPW-153245 [merch] make shadow elements spit custom events (#42)
  MWPW-148229  Left Rail filter hover Text  (#43)
  Stop using code which resolves default display tax label value per country and segment (#27)
  Mwpw-147034: Custom border color + badge/border color decoupling [Mer… (#15)
  MWPW-154026: Long CTAs fall in the second line in merch card footer (#38)

# Conflicts:
#	libs/commerce.js
#	libs/mas.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants