Stop using code which resolves default display tax label value per country and segment #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untry and segment
|
npeltier
approved these changes
Jul 8, 2024
3ch023
approved these changes
Jul 8, 2024
|
@bozojovicic could you add a tmp milo branch link please? for us and Mili to do a final check |
Milo PR adobecom/milo#2543 |
thx, please next time also put it in the description |
rohitsahu
pushed a commit
that referenced
this pull request
Jul 26, 2024
* main: MWPW-153245 [merch] make shadow elements spit custom events (#42) MWPW-148229 Left Rail filter hover Text (#43) Stop using code which resolves default display tax label value per country and segment (#27) Mwpw-147034: Custom border color + badge/border color decoupling [Mer… (#15) MWPW-154026: Long CTAs fall in the second line in merch card footer (#38) # Conflicts: # libs/commerce.js # libs/mas.js # libs/merch-card-all.js # libs/merch-card.js # web-components/src/merch-card.js
rohitsahu
pushed a commit
that referenced
this pull request
Aug 7, 2024
* 'ost' of https://github.com/adobecom/mas: Update mas.js Revert "resolved conflicts" Update mas.js updated deps MWPW-153599: M@S Studio solution design (#36) moved delay method Update package-lock.json Mwpw-151480: move of commerce and web components to milo (#49) [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (#45) MWPW-153245 [merch] make shadow elements spit custom events (#42) MWPW-148229 Left Rail filter hover Text (#43) Stop using code which resolves default display tax label value per country and segment (#27) Mwpw-147034: Custom border color + badge/border color decoupling [Mer… (#15) MWPW-154026: Long CTAs fall in the second line in merch card footer (#38) # Conflicts: # libs/commerce.js # libs/mas.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuts off the code added for resolving default value for "display tax" per country and segment
until problems in the content are fixed
to unblock the development of other mas/commerce features.
Milo PR adobecom/milo#2543
Milo branch https://github.com/bozojovicic/milo/tree/mwpw143069revert
Fix #MWPW-143069
Test URLs: