Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-153808: fix duplicate tax label #2614

Merged
merged 2 commits into from
Jul 23, 2024
Merged

MWPW-153808: fix duplicate tax label #2614

merged 2 commits into from
Jul 23, 2024

Conversation

3ch023
Copy link
Contributor

@3ch023 3ch023 commented Jul 23, 2024

Copy link
Contributor

aem-code-sync bot commented Jul 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jul 23, 2024

Page Scores Audits Google
/de/drafts/mariia/price-cta?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@3ch023 3ch023 added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jul 23, 2024
@3ch023 3ch023 changed the title Hotfix MWPW-153808: fix duplicate tax label Jul 23, 2024
@npeltier npeltier self-requested a review July 23, 2024 17:59
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (2c5b9a4) to head (4dc84a1).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2614   +/-   ##
=======================================
  Coverage   95.67%   95.68%           
=======================================
  Files         170      170           
  Lines       45302    45302           
=======================================
+ Hits        43343    43347    +4     
+ Misses       1959     1955    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3ch023 3ch023 added the run-nala Run Nala Test Automation against PR label Jul 23, 2024
@milo-pr-merge milo-pr-merge bot merged commit d739e72 into stage Jul 23, 2024
28 checks passed
@milo-pr-merge milo-pr-merge bot deleted the hotfix branch July 23, 2024 18:16
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 23, 2024
rohitsahu pushed a commit to rohitsahu/milo that referenced this pull request Jul 26, 2024
* stage:
  MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632)
  mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618)
  Correct error messages for duplicate files on the stage to main workflow (adobecom#2621)
  MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610)
  Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627)
  MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615)
  Fix for errors in dynamically loaded scripts in test cases (adobecom#2619)
  MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593)
  Bootstrapper script for milo feds blocks (adobecom#2560)
  Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612)
  MWPW-146743 Improve Article Header Performance (adobecom#2577)
  MWPW-153808: fix duplicate tax label (adobecom#2614)
  MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565)
  Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611)
  [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605)
  [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599)
  MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604)
  [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597)
  MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533)

# Conflicts:
#	libs/deps/merch-card.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants