MWPW-146743 Improve Article Header Performance #2577
Conversation
meganthecoder
requested review from
JasonHowellSlavin,
Brandon32 and
rgclayton
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2577 +/- ##
==========================================
+ Coverage 95.67% 95.70% +0.02%
==========================================
Files 170 169 -1
Lines 45302 45315 +13
==========================================
+ Hits 43343 43367 +24
+ Misses 1959 1948 -11 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -1,16 +1,15 @@ | |||
| import { createTag, getMetadata, getConfig } from '../../utils/utils.js'; | |||
| import { copyToClipboard } from '../../utils/tools.js'; | |||
There was a problem hiding this comment.
Is copyToClipboard in tools.js used outside of article header?
There was a problem hiding this comment.
No, not in milo but I didn't want to delete it in case a consumer is using it.
|
To test invalid date: https://main--milo--adobecom.hlx.page/drafts/methomas/article-header-invalid-date |
|
Reminder to set the |
meganthecoder
force-pushed
the
perf-refactor-article-header
branch
from
8c9d3a2 to
c11c268
Compare
* stage: MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) MWPW-146743 Improve Article Header Performance (adobecom#2577) MWPW-153808: fix duplicate tax label (adobecom#2614) MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565) Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611) [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605) [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599) MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604) [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597) MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533) # Conflicts: # libs/deps/merch-card.js
Made various updates to Article Header in order to reduce LCP on blogs:
Resolves: MWPW-146743
Results (hlx.live testing):
Test URLs:
Bacom Blog:
Brand Blog: