-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) #2599
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2599 +/- ##
==========================================
- Coverage 95.86% 95.86% -0.01%
==========================================
Files 176 176
Lines 46211 46211
==========================================
- Hits 44300 44298 -2
- Misses 1911 1913 +2 ☔ View full report in Codecov by Sentry. |
@sonawanesnehal3 - I remember @overmyheadandbody implemented support for this already, I am able to see it running with forcing the |
Thanks @narcis-radu. |
Hi @sonawanesnehal3 , can you please confirm on the region selection in locale page , when JP locale is updated in region doc, on change region selection is still seen as US.Can you please advise on this. |
Please test the localisation flow in this PR as localisation flow is fixed in this PR. |
Validation done on the below url :
|
This may need to be reverted, as it affects current behavior: Current look: https://main--milo--adobecom.hlx.page/drafts/ramuntea/footer-refactor-variant Look after merging this PR: https://stage--milo--adobecom.hlx.page/drafts/ramuntea/footer-refactor-variant I'm still not clear on what the intention for this PR was, as the logic and styles were working as expected. CC: @bandana147, @sharmrj, @spadmasa, @narcis-radu |
Also tried looking at the links provided in this PR, but the logic is trying to load https://stage--milo--adobecom.hlx.page/federal/footer/fragments/regions1.plain.html, which doesn't exist |
* stage: MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) MWPW-146743 Improve Article Header Performance (adobecom#2577) MWPW-153808: fix duplicate tax label (adobecom#2614) MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565) Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611) [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605) [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599) MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604) [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597) MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533) # Conflicts: # libs/deps/merch-card.js
Add styling for region picker drop-up variant (without hash)
Resolves: MWPW-154795
Test URLs:
Before styles applied :
After styles applied :
QA : Sample Page