-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrapper script for milo feds blocks #2560
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2560 +/- ##
=======================================
Coverage 95.67% 95.68%
=======================================
Files 170 173 +3
Lines 45302 45366 +64
=======================================
+ Hits 43342 43407 +65
+ Misses 1960 1959 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. 🚀 Do I understand it right that the consuming project would need to add the appropriate <meta>
attributes themselves before loading the boostrap function?
So for the global-navigation / global-footer nothing changes, but the consuming project add the <meta>
attributes to the header, for fetching a specific footer/nav?
@mokimo
Adding it to the meta tag in their project also works. |
This PR is currently in the |
* stage: MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) MWPW-146743 Improve Article Header Performance (adobecom#2577) MWPW-153808: fix duplicate tax label (adobecom#2614) MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565) Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611) [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605) [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599) MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604) [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597) MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533) # Conflicts: # libs/deps/merch-card.js
* stage: [MWPW-153611] [Gray Box] environment aware links (adobecom#2622) MWPW-153580: Add Opt-In Feature for CaaS Badge Display (adobecom#2625) [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (adobecom#2628) MWPW-150557 - Split Marquee CLS issues on consuming sites (adobecom#2636) Mwpw 147034: Custom border color + badge/border color decoupling [merch card] (adobecom#2613) [MWPW-151517] - Remove condition for promobar hidden on mobile from gnav (adobecom#2538) MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) # Conflicts: # libs/deps/merch-card.js
Adding a bootstrapper script which would initiate fed's global footer milo block which can be consumed by non milo client.
JIRA - https://jira.corp.adobe.com/browse/MWPW-152861
Resolves: MWPW-152861
Test URLs:
Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://feds--milo--adobecom.hlx.page/?martech=off
QA: sample-page
Solution design
@sonawanesnehal3