-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-153580: Add Opt-In Feature for CaaS Badge Display #2625
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2625 +/- ##
=======================================
Coverage 95.69% 95.70%
=======================================
Files 169 172 +3
Lines 45295 45365 +70
=======================================
+ Hits 43345 43416 +71
+ Misses 1950 1949 -1 ☔ View full report in Codecov by Sentry. |
I was in the process of raising the PR last night just before the end of the work day but didn’t have enough time to finish it up until today. The PR is now complete with all the documentation written and tests updated. I have also addressed the failing checks and everything should be in order now :)
|
Skipped merging 2625: MWPW-153580: Add Opt-In Feature for CaaS Badge Display due to failing checks |
Skipped merging 2625: MWPW-153580: Add Opt-In Feature for CaaS Badge Display due to failing checks |
Skipped merging 2625: MWPW-153580: Add Opt-In Feature for CaaS Badge Display due to failing checks |
1 similar comment
Skipped merging 2625: MWPW-153580: Add Opt-In Feature for CaaS Badge Display due to failing checks |
* stage: [MWPW-153611] [Gray Box] environment aware links (adobecom#2622) MWPW-153580: Add Opt-In Feature for CaaS Badge Display (adobecom#2625) [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (adobecom#2628) MWPW-150557 - Split Marquee CLS issues on consuming sites (adobecom#2636) Mwpw 147034: Custom border color + badge/border color decoupling [merch card] (adobecom#2613) [MWPW-151517] - Remove condition for promobar hidden on mobile from gnav (adobecom#2538) MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) # Conflicts: # libs/deps/merch-card.js
TLDR
We added a checkbox in CaaS tool configurator to enable a new badging feature.
Milo only contains the logic for toggling a checkbox true or false.
All the actual implementation is done on the CaaS side.
Note: This feature only affects an authoring tool. The LH scores tested by the GH actions are irrelevant in this context.
Description
This pull request introduces a new feature for Milo, allowing authors to opt-in to display badges on their CaaS cards. Previously, Milo was incorrectly sending the
primaryTag
information for each card. Specifically, for Milo (using the postXDM service), badge label information was being sent incorrectly as an ID (in the wrong structure), missing the tag's title and localized values.To resolve this, we will use static tag data inside Chimera IO to look up the correct tag title based on the ID passed on by Milo. This approach is much easier than fixing the postXDM service and performing a database migration in OpenSearch.
By implementing this feature, Milo authors can now choose to display badges by enabling a checkbox.
Resolves: MWPW-153580
Additional Context
For cards from Dexter, badges should always display by default. For cards from Milo, authors may not expect badges unless they opt in. This prevents unintended badge displays for Milo authors who did not expect them (by accidentally authoring
primaryTag
fields without realizing they show badges)Solution
Handling Different Content Origins:
We have consumers from Dexter and Milo.
Code Changes:
Updated Code
Backend Code:
CaaS UI Code:
Milo Code:
Testing
Test URLs:
Before: https://main--milo--adobecom.hlx.page/tools/caas?martech=off
After: https://MWPW-153580--milo--adobecom.hlx.page/tools/caas?martech=off
By merging this pull request, we will ensure that authors have control over badge visibility based on the content origin and their preferences.