MWPW-154026: Long CTAs fall in the second line in merch card footer #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirafedas
requested review from
yesil,
npeltier,
Axelcureno,
3ch023,
bozojovicic and
seanchoi-dev
mirafedas
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2565 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 170 170
Lines 45302 45302
=======================================
Hits 43342 43342
Misses 1960 1960 ☔ View full report in Codecov by Sentry. |
3ch023
approved these changes
Jul 12, 2024
npeltier
approved these changes
Jul 12, 2024
|
|
@mirafedas verified |
|
Reminder to set the |
narcis-radu
reviewed
Jul 15, 2024
libs/deps/merch-card.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| // branch: main commit: 258ad3d851cc4945eae2aab2dcc80a8d0c14d861 Fri, 28 Jun 2024 14:19:21 GMT | |||
| import{html as a,LitElement as j}from"/libs/deps/lit-all.min.js";import{LitElement as q,html as T,css as F}from"/libs/deps/lit-all.min.js";var s=class extends q{static properties={size:{type:String,attribute:!0},src:{type:String,attribute:!0},alt:{type:String,attribute:!0},href:{type:String,attribute:!0}};constructor(){super(),this.size="m",this.alt=""}render(){let{href:e}=this;return e?T`<a href="${e}"> | |||
| // branch: MWPW-154026-cta-long-text commit: b9a46be0956fd4df485c08a14cb59a0e51814c78 Fri, 12 Jul 2024 14:20:01 GMT | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It should be built from main
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
skumar09
added
run-nala
|
@mirafedas - I think you need to build from main now and @Roycethan will have to add 'Ready for Stage' label |
|
@narcis-radu will do it as soon as the corresponding mas PR is merged: adobecom/mas#38 . I added this link in the PR description just now and will do the same in upcoming PRs to have a quick reference. Thanks for checking! :) |
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Jul 26, 2024
* stage: MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) MWPW-146743 Improve Article Header Performance (adobecom#2577) MWPW-153808: fix duplicate tax label (adobecom#2614) MWPW-154026: Long CTAs fall in the second line in merch card footer (adobecom#2565) Revert "[MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash)" (adobecom#2611) [AUTOMATED-PR] Update imslib.min.js dependency (adobecom#2605) [MWPW-154795] Style Feds Global-footer region picker drop-up variant (without hash) (adobecom#2599) MWPW-143053 [MEP] Request for New Personalization Tag - CC Paid (adobecom#2604) [MWPW-152674] [Gray Box] Desktop gnav not hidden when device view is open (adobecom#2597) MWPW-150566 - 🆕 Editorial-Card block (adobecom#2533) # Conflicts: # libs/deps/merch-card.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CTA text is long and there is a secure transaction label displayed, the CTA extends beyond the card because the secure transaction label has its height set to 100%. Removing this property does not break the footer elements' alignment in any card variation.
I added a block of four cards with long CTA text for testing.
Corresponding Mas PR (has to merged before I can build it from main): adobecom/mas#38
Resolves: MWPW-154026
Before:
After:
Test URLs:
Before:
After: