Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mwpw 142267: What's included style fixes #40

Closed
wants to merge 2 commits into from
Closed

Mwpw 142267: What's included style fixes #40

wants to merge 2 commits into from

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Jul 15, 2024 •
edited
Loading

@Axelcureno Axelcureno requested review from npeltier and 3ch023 July 15, 2024 21:07
@Axelcureno Axelcureno self-assigned this Jul 15, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 15, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 16, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Axelcureno
Axelcureno commented Jul 16, 2024
View reviewed changes
milo-libs/merch-card-collection.js Outdated
@@ -0,0 +1,147 @@
// branch: MWPW-142267 commit: 25320da3fd942c99cfcd7ec563122d0a7e755d9f Mon, 15 Jul 2024 22:23:34 GMT
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know in milo we should generate from main, is that also the case here @3ch023 ? Sorry for the confusion.

cc @npeltier

@Roycethan
Copy link
Collaborator

The remaining un-covered AC's and Issues are noted in https://jira.corp.adobe.com/browse/MWPW-154370 and moving forward with covered use cases for facilitating authoring...

@Roycethan
Copy link
Collaborator

Validated in Milo, @npeltier / @3ch023 Plz raise my permissions to add labels to this repo

@Axelcureno
Copy link
Member Author

Moved to: adobecom/milo#2674

@Axelcureno Axelcureno closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npeltier npeltier npeltier approved these changes

@3ch023 3ch023 Awaiting requested review from 3ch023

Assignees

@Axelcureno Axelcureno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Axelcureno @Roycethan @npeltier