Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) #2554

Axelcureno · 2024-07-09T22:22:27Z

Introduces Merch What's Included and Merch Mnemonic List web components for TwP What's included screen.

Includes: https://github.com/adobecom/mas/pull/4/files

Test URLs:

aem-code-sync · 2024-07-09T22:22:30Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

4a53741 ✅ (latest)
df184c9 ✅
ed12ec8 ✅
e7f2fb1 ✅
82a00b2 ✅
93280ae ✅
29e3cf1 ✅
8815dbc ✅
57abb1b ✅
afab6ee ✅
3cbb527 ✅
ca1f4fb ✅
5ea4544 ✅
1cbc547 ✅
a178fa6 ✅
46fe52c ✅
024f2b8 ✅
6f6a0af ✅
954105d ✅
893a099 ❌

aem-code-sync · 2024-07-09T22:22:53Z

Page	Scores	Audits	Google
/drafts/axel/block-samples/twp/illustrator

codecov · 2024-07-09T22:25:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (8e6ca69) to head (4a53741).
Report is 15 commits behind head on stage.

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #2554   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         175      176    +1     
  Lines       46064    46151   +87     
=======================================
+ Hits        44150    44234   +84     
- Misses       1914     1917    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-10T01:18:25Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

3ch023 · 2024-07-11T10:42:25Z

libs/deps/merch-mnemonic-list.js

@@ -0,0 +1,48 @@
+// branch: MWPW-142267 commit: db56fa6d1f49aa580f3da94842ffb9e73516ee18 Mon, 08 Jul 2024 21:06:50 GMT


since this PR was already merged in mas repository these files should now be regenerated from /main branch

npeltier · 2024-07-12T08:13:32Z

libs/blocks/merch-twp/merch-twp.js

+      whatsIncludedFragment,
+    );
+    twp.append(whatsIncludedSlot);


Suggested change

whatsIncludedFragment,

);

twp.append(whatsIncludedSlot);

whatsIncludedFragment,

{ parent : twp },

);

npeltier · 2024-07-12T08:14:46Z

libs/deps/merch-card.js

@@ -1,7 +1,6 @@
-// branch: main commit: 258ad3d851cc4945eae2aab2dcc80a8d0c14d861 Fri, 28 Jun 2024 14:19:21 GMT
-import{html as a,LitElement as j}from"/libs/deps/lit-all.min.js";import{LitElement as q,html as T,css as F}from"/libs/deps/lit-all.min.js";var s=class extends q{static properties={size:{type:String,attribute:!0},src:{type:String,attribute:!0},alt:{type:String,attribute:!0},href:{type:String,attribute:!0}};constructor(){super(),this.size="m",this.alt=""}render(){let{href:e}=this;return e?T`<a href="${e}">
+import{html as o,LitElement as te,nothing as re}from"/libs/deps/lit-all.min.js";import{LitElement as Y,html as M,css as Q}from"/libs/deps/lit-all.min.js";var h=class extends Y{static properties={size:{type:String,attribute:!0},src:{type:String,attribute:!0},alt:{type:String,attribute:!0},href:{type:String,attribute:!0}};constructor(){super(),this.size="m",this.alt=""}render(){let{href:e}=this;return e?M`<a href="${e}">


please use milo build cc @3ch023

(we need to see branch & commit hash)

npeltier · 2024-07-12T08:15:25Z

libs/deps/merch-mnemonic-list.js

@@ -0,0 +1,30 @@
+import{html as e,css as i,LitElement as s}from"/libs/deps/lit-all.min.js";var t=class extends s{static styles=i`


npeltier · 2024-07-12T08:15:34Z

libs/deps/merch-twp-d2p.js

@@ -1,4 +1,3 @@
-// branch: develop commit: b3f6608faa10db8d0187b310044d4690d063f1bf Sun, 09 Jun 2024 06:39:58 GMT


npeltier · 2024-07-12T08:15:45Z

libs/deps/merch-whats-included.js

@@ -0,0 +1,44 @@
+import{html as e,css as o,LitElement as l}from"/libs/deps/lit-all.min.js";var t=class extends l{static styles=o`


…to reset to Axels commit to avoid 'callout' change

Axelcureno · 2024-07-12T19:35:50Z

@Roycethan please validate this one 🙏🏼

Roycethan · 2024-07-12T23:25:15Z

@Roycethan please validate this one 🙏🏼

@Axelcureno In the implemented modal the below AC's are not implemented, hence assigning back to you thanks
AC: Ability for authors to add CTA which will take users to the cart
AC: Ability for that CTA to know what the user's subscription option was from the previous screen (nice to have)
AC: Back CTA so that users can go back to the previous screen (Note: back cta needs to be smart in knowing if the user was on screen 1 or a 2nd screen in the case of modal with 2 screens already)

Roycethan · 2024-07-16T02:49:38Z

The remaining un-covered AC's and Issues are noted in https://jira.corp.adobe.com/browse/MWPW-154370 and moving forward with covered use cases for facilitating authoring...

milo-pr-merge · 2024-07-16T09:16:06Z

Skipped 2554: Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) due to file overlap. Merging will be attempted in the next batch

* stage: Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) (adobecom#2554) MWPW-149124 Improve Focus Page for Performance Improvement Tiger Team (adobecom#2391) Correctly send the created PR slacks (adobecom#2566) MWPW-153167: caas-config change to enable hiding date detail information (adobecom#2553) MWPW-152016 - Localization target preview for transcreation (adobecom#2564) Relax CORS restrictions for module imports (adobecom#2549) MWPW-153600 [PEP] loader bar on PEP prompt is seen loaded Left to right in RTL locale (adobecom#2548) MWPW-146962 [milo] Text link behaving like button in FAQ section (adobecom#2530) MWPW-152280 MEP: Only preload fragments that are in the 1st section (adobecom#2525) MWPW-152697 Fix Marketo mobile horizontal scroll (adobecom#2514) MWPW-151513: Search results vanished when user clicks on Marquee CTA:Start free trail (adobecom#2406) MWPW-154013 PEP prompt redirection is broken in stage after the PEP dismissal PR merge (adobecom#2547) MWPW-153962: Introduce maslibs query parameter (adobecom#2544) Central georouting support (adobecom#2531) [MWPW-152278] Avoid empty CSS requests (adobecom#2524) MWPW-152918 Fix Marketo button font (adobecom#2513) # Conflicts: # libs/deps/merch-card.js

Axelcureno added 4 commits July 8, 2024 16:51

MWPW-142267: What's Included screen (TwP)

893a099

Update merch-whats-included.css

954105d

Update merch-whats-included.css

6f6a0af

Update merch-whats-included.css

024f2b8

Axelcureno added needs-verification PR requires E2E testing by a reviewer merch card labels Jul 9, 2024

Axelcureno self-assigned this Jul 9, 2024

Axelcureno requested a review from a team as a code owner July 9, 2024 22:22

Axelcureno changed the title ~~Mwpw 142267:~~ Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) Jul 9, 2024

npeltier added commerce merch card and removed merch card labels Jul 10, 2024

3ch023 reviewed Jul 11, 2024

View reviewed changes

3ch023 approved these changes Jul 11, 2024

View reviewed changes

Axelcureno added 3 commits July 11, 2024 13:14

updated libs from main

46fe52c

Update merch-whats-included.js

a178fa6

updated deps

1cbc547

aem-code-sync bot temporarily deployed to MWPW-142267 July 11, 2024 20:23 Inactive

npeltier requested changes Jul 12, 2024

View reviewed changes

3ch023 added the run-nala Run Nala Test Automation against PR label Jul 12, 2024

address review comments. 'HEAD' branch instead of main because I had …

5ea4544

…to reset to Axels commit to avoid 'callout' change

aem-code-sync bot temporarily deployed to mwpw-142267 July 12, 2024 10:04 Inactive

npeltier approved these changes Jul 12, 2024

View reviewed changes

Axelcureno requested a review from Roycethan July 12, 2024 19:35

Axelcureno added 4 commits July 15, 2024 09:50

Update merch-whats-included.css

ca1f4fb

Update merch-whats-included.css

3cbb527

Update merch-whats-included.css

afab6ee

Update merch-whats-included.css

57abb1b

aem-code-sync bot temporarily deployed to mwpw-142267 July 15, 2024 19:53 Inactive

Update merch-whats-included.css

8815dbc

aem-code-sync bot temporarily deployed to mwpw-142267 July 15, 2024 19:57 Inactive

Axelcureno mentioned this pull request Jul 15, 2024

Mwpw 142267: What's included style fixes adobecom/mas#40

Closed

style fixes

29e3cf1

aem-code-sync bot temporarily deployed to mwpw-142267 July 15, 2024 21:08 Inactive

updated deps

93280ae

aem-code-sync bot temporarily deployed to mwpw-142267 July 15, 2024 22:20 Inactive

Axelcureno added 2 commits July 15, 2024 15:23

h3 styles

82a00b2

responsive width

e7f2fb1

aem-code-sync bot temporarily deployed to mwpw-142267 July 15, 2024 22:31 Inactive

Axelcureno added 3 commits July 15, 2024 15:33

Update merch-whats-included.css

ed12ec8

removed event listener

df184c9

unit tests

4a53741

Roycethan added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Jul 16, 2024

3ch023 added the Ready for Stage label Jul 16, 2024

mokimo merged commit d932b35 into stage Jul 16, 2024
21 checks passed

mokimo deleted the mwpw-142267 branch July 16, 2024 09:49

This was referenced Jul 16, 2024

[Release] Stage to Main #2571

Merged

Stage pr created to slack stage #2572

Merged

Axelcureno mentioned this pull request Jul 31, 2024

Mwpw 142267: What's included style fixes #2674

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) #2554

Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) #2554

Axelcureno commented Jul 9, 2024 •

edited by Roycethan

Loading

aem-code-sync bot commented Jul 9, 2024 •

edited

Loading

aem-code-sync bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024

3ch023 Jul 11, 2024

Axelcureno Jul 11, 2024 •

edited

Loading

npeltier Jul 12, 2024

3ch023 Jul 12, 2024

npeltier Jul 12, 2024

npeltier Jul 12, 2024

npeltier Jul 12, 2024

npeltier Jul 12, 2024

npeltier Jul 12, 2024

3ch023 Jul 12, 2024

Axelcureno commented Jul 12, 2024

Roycethan commented Jul 12, 2024

Roycethan commented Jul 16, 2024

milo-pr-merge bot commented Jul 16, 2024

		@@ -0,0 +1,48 @@
		// branch: MWPW-142267 commit: db56fa6d1f49aa580f3da94842ffb9e73516ee18 Mon, 08 Jul 2024 21:06:50 GMT

		@@ -0,0 +1,30 @@
		import{html as e,css as i,LitElement as s}from"/libs/deps/lit-all.min.js";var t=class extends s{static styles=i`

		@@ -1,4 +1,3 @@
		// branch: develop commit: b3f6608faa10db8d0187b310044d4690d063f1bf Sun, 09 Jun 2024 06:39:58 GMT

		@@ -0,0 +1,44 @@
		import{html as e,css as o,LitElement as l}from"/libs/deps/lit-all.min.js";var t=class extends l{static styles=o`

Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) #2554

Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) #2554

Conversation

Axelcureno commented Jul 9, 2024 • edited by Roycethan Loading

aem-code-sync bot commented Jul 9, 2024 • edited Loading

aem-code-sync bot commented Jul 9, 2024 • edited Loading

codecov bot commented Jul 9, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 10, 2024

Choose a reason for hiding this comment

Axelcureno Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Axelcureno commented Jul 12, 2024

Roycethan commented Jul 12, 2024

Roycethan commented Jul 16, 2024

milo-pr-merge bot commented Jul 16, 2024

Axelcureno commented Jul 9, 2024 •

edited by Roycethan

Loading

aem-code-sync bot commented Jul 9, 2024 •

edited

Loading

aem-code-sync bot commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 9, 2024 •

edited

Loading

Axelcureno Jul 11, 2024 •

edited

Loading