Skip to content

Commit

Permalink
add 1-second timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
John Pratt committed Jan 16, 2025
1 parent 3a1b9eb commit a88f83a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions nala/features/personalization/target-on.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,21 @@ test(`${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => {
await test.step('step-1: verify default test page', async () => {
console.info(`[Test Page]: ${defaultURL}`);
await page.goto(defaultURL);
await page.waitForTimeout(1000);
await expect(marquee.headingXL).toHaveText('Heading XL Marquee standard medium left');
});

await test.step('step-2: verify metadata test page', async () => {
console.info(`[Test Page]: ${metadataURL}`);
await page.goto(metadataURL);
await page.waitForTimeout(1000);
await expect(marquee.headingXL).toHaveText('Target is running');

Check failure on line 29 in nala/features/personalization/target-on.test.js

View workflow job for this annotation

GitHub Actions / Running Nala E2E UI Tests (20.x)

[milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests

1) [milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests,@targeton0 @smoke @regression @milo › step-2: verify metadata test page Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: locator('.marquee').first().locator('.heading-xl').first() Expected string: "Target is running" Received string: "Heading XL Marquee standard medium left" Call log: - expect.toHaveText with timeout 5000ms - waiting for locator('.marquee').first().locator('.heading-xl').first() - locator resolved to <h2 class="heading-xl" id="heading-xl-marquee-standard-medium-left">…</h2> - unexpected value "Heading XL Marquee standard medium left" 27 | await page.goto(metadataURL); 28 | await page.waitForTimeout(1000); > 29 | await expect(marquee.headingXL).toHaveText('Target is running'); | ^ 30 | }); 31 | 32 | await test.step('step-3: verify parameter test page', async () => { at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:29:37 at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:25:3

Check failure on line 29 in nala/features/personalization/target-on.test.js

View workflow job for this annotation

GitHub Actions / Running Nala E2E UI Tests (20.x)

[milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests

1) [milo-live-chromium] › features/personalization/target-on.test.js:12:5 › @check for running Target tests,@targeton0 @smoke @regression @milo › step-2: verify metadata test page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: locator('.marquee').first().locator('.heading-xl').first() Expected string: "Target is running" Received string: "Heading XL Marquee standard medium left" Call log: - expect.toHaveText with timeout 5000ms - waiting for locator('.marquee').first().locator('.heading-xl').first() - locator resolved to <h2 class="heading-xl" id="heading-xl-marquee-standard-medium-left">…</h2> - unexpected value "Heading XL Marquee standard medium left" - locator resolved to <h2 class="heading-xl" id="heading-xl-marquee-standard-medium-left">…</h2> - unexpected value "Heading XL Marquee standard medium left" 27 | await page.goto(metadataURL); 28 | await page.waitForTimeout(1000); > 29 | await expect(marquee.headingXL).toHaveText('Target is running'); | ^ 30 | }); 31 | 32 | await test.step('step-3: verify parameter test page', async () => { at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:29:37 at /home/runner/work/milo/milo/nala/features/personalization/target-on.test.js:25:3
});

await test.step('step-3: verify parameter test page', async () => {
console.info(`[Test Page]: ${parameterURL}`);
await page.goto(parameterURL);
await page.waitForTimeout(1000);
await expect(marquee.headingXL).toHaveText('Target is running');
});
});

0 comments on commit a88f83a

Please sign in to comment.