MWPW-144108: Project PEP unit tests #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-bogos
added
zero-impact
trivial
|
Add some dummy links that just go to the milo homepage to make the PSI check pass |
|
|
No QA needed , PEP E2E testing will be done on https://jira.corp.adobe.com/browse/MWPW-142861 |
SilviuLCF
approved these changes
Apr 12, 2024
mokimo
approved these changes
Apr 12, 2024
|
Reminder to set the |
|
Since this is open against a feature branch, has approvals, all tests are passing; I will merge for now. |
overmyheadandbody
pushed a commit
that referenced
this pull request
Apr 29, 2024
* unit tests for pep * fixes for gnav unit tests * optimizing pep unit tests
Merged
Blainegunn
pushed a commit
that referenced
this pull request
May 3, 2024
* [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * MWPW-141021: Project PEP Accessibility Requirements (#1853) * [MWPW-139990] PEP prompt * pep accessibility requirements * hotfix * hotfixes * initial focus on close icon * implementing feedback * hotfix * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * implementing feedback * css variables * hotfix: moved css variables * hotfix --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * MWPW-142622: [Project PEP] Close button focus (#1897) * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * hotfix: blue outline on close button when focused * hotfix --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951) * pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label * [MWPW-141050] Fetch profile for PEP * [MWPW-141025] Integrate XLG with PEP * [MWPW-142625] PEP relative to App Switcher * MWPW-144108: Project PEP unit tests (#2136) * unit tests for pep * fixes for gnav unit tests * optimizing pep unit tests * MWPW-146582: PEP fixes (#2144) * added aria-label attribute to pep close button * force load imslib.min.js * revert force load imslib.min.js * changed aria label for close button * pep final touches * [MWPW-147145] Allow SVG in PEP Prompt; change redirect method --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Robert Bogos <robert.adobe.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for project PEP
Related Issue
Resolves: MWPW-144108
Testing instructions
web-test-runner.config.mjsby addingfiles: ['./test/features/webapp-prompt/webapp-prompt.test.js'], to the default exported json (this will help target thewebapp-prompt.test.jsfor tests)npm run test:file:watchScreenshots:
Test URLs
Milo: