MWPW-141020: [Project PEP] Implement Analytics Enablement #1951

robert-bogos · 2024-03-04T09:09:14Z

Description

This PR enables analytics for PEP

Related Issue

Resolves: MWPW-141020

Testing instructions

open the after test URL and wait for the PEP modal to show up
open dev tools and watch the network tab, searching for calls to https://sstats.adobe.com/ee/irl1/v1/interact
click on the X button
the request payload for searched api call should have events[0].xdm.web.webInteraction.name equal to "Close Modal|PEP Modal_Photoshop" ( see screenshots )
delete the dismissedAppPrompts cookie so that the modal will show up again on refresh
click the "Stay on this page" button
the request payload for searched api call should have events[0].xdm.web.webInteraction.name equal to "Stay on this page|PEP Modal_Photoshop" ( see screenshots )

Screenshots

Test URLs

Milo:

aem-code-sync · 2024-03-04T09:09:34Z

Page	Scores	Audits	Google
/drafts/rbogos/pep-prompt?imsClientId=fedsmilo

codecov · 2024-03-04T09:11:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (project-pep@39ddedd). Click here to learn what that means.

Additional details and impacted files

@@              Coverage Diff               @@
##             project-pep    #1951   +/-   ##
==============================================
  Coverage               ?   95.63%           
==============================================
  Files                  ?      159           
  Lines                  ?    41228           
  Branches               ?        0           
==============================================
  Hits                   ?    39428           
  Misses                 ?     1800           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/features/webapp-prompt/webapp-prompt.js

overmyheadandbody

Using entitlements would not lead to the expected labels, we should have a new product name field instead.

libs/features/webapp-prompt/webapp-prompt.js

libs/scripts/delayed.js

libs/features/webapp-prompt/webapp-prompt.js

overmyheadandbody

One note, but looks good otherwise

libs/features/webapp-prompt/webapp-prompt.js

SilviuLCF · 2024-03-07T09:30:53Z

Ready for merge
QA verified - https://jira.corp.adobe.com/browse/MWPW-141020

honstar · 2024-03-19T12:22:46Z

As per JIRA ticket, this PR is Ready for Stage, hence marking respectively.

overmyheadandbody · 2024-03-20T10:24:22Z

Hey @honstar! This was actually opened against a feature branch, the code for the whole functionality is not ready for stage or production, as we're waiting for additional details. I've added this detail to the stage PR already.

It might make sense to bookmark a filter with stories ready to be merged on one of the Slack channels, such as https://github.com/adobecom/milo/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+Stage%22+base%3Astage

As a personal opinion, I think it's the developer's job to make sure they follow all the steps to have their PR looked at by the MPoC, MPoCs should not have to sort out PRs. We should probably also come up with a rule that if something is open for more than X weeks, it automatically gets closed.

CC: @SilviuLCF

* pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

) * pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

* pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

* [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * MWPW-141021: Project PEP Accessibility Requirements (#1853) * [MWPW-139990] PEP prompt * pep accessibility requirements * hotfix * hotfixes * initial focus on close icon * implementing feedback * hotfix * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * implementing feedback * css variables * hotfix: moved css variables * hotfix --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * MWPW-142622: [Project PEP] Close button focus (#1897) * [MWPW-139990] PEP prompt * MWPW-142617: Microsoft Edge & Chrome Win - progress bar not completely loaded (#1882) * hotfix * refactor: changed loader animation logic * update * revert update * more gpu acceleration for pep loader * hotfix * hotfix * [MWPW-141023] PEP authoring (#1889) * hotfix: blue outline on close button when focused * hotfix --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> * MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951) * pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label * [MWPW-141050] Fetch profile for PEP * [MWPW-141025] Integrate XLG with PEP * [MWPW-142625] PEP relative to App Switcher * MWPW-144108: Project PEP unit tests (#2136) * unit tests for pep * fixes for gnav unit tests * optimizing pep unit tests * MWPW-146582: PEP fixes (#2144) * added aria-label attribute to pep close button * force load imslib.min.js * revert force load imslib.min.js * changed aria label for close button * pep final touches * [MWPW-147145] Allow SVG in PEP Prompt; change redirect method --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Robert Bogos <robert.adobe.github@gmail.com>

pep analytics

45aa67d

robert-bogos added the needs-verification PR requires E2E testing by a reviewer label Mar 4, 2024

robert-bogos requested review from narcis-radu, overmyheadandbody and mokimo March 4, 2024 09:09

robert-bogos self-assigned this Mar 4, 2024

robert-bogos requested a review from a team as a code owner March 4, 2024 09:09

mokimo reviewed Mar 4, 2024

View reviewed changes

libs/features/webapp-prompt/webapp-prompt.js Outdated Show resolved Hide resolved

overmyheadandbody requested changes Mar 4, 2024

View reviewed changes

narcis-radu reviewed Mar 4, 2024

View reviewed changes

libs/features/webapp-prompt/webapp-prompt.js Outdated Show resolved Hide resolved

libs/features/webapp-prompt/webapp-prompt.js Outdated Show resolved Hide resolved

robert-bogos added 3 commits March 4, 2024 18:29

hotfix

947654f

hotfix

240d1ab

hotfix

84e60a2

robert-bogos requested review from narcis-radu, mokimo and overmyheadandbody March 4, 2024 16:47

overmyheadandbody approved these changes Mar 5, 2024

View reviewed changes

libs/features/webapp-prompt/webapp-prompt.js Outdated Show resolved Hide resolved

removed capitalization from analytics label

1fc8206

mokimo approved these changes Mar 7, 2024

View reviewed changes

robert-bogos requested a review from SilviuLCF March 7, 2024 08:09

robert-bogos assigned SilviuLCF Mar 7, 2024

SilviuLCF approved these changes Mar 7, 2024

View reviewed changes

SilviuLCF added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 7, 2024

honstar added the Ready for Stage label Mar 19, 2024

Blainegunn merged commit 9b369f1 into adobecom:project-pep Mar 19, 2024
16 checks passed

Blainegunn mentioned this pull request Mar 19, 2024

[Release] Stage to Main #2043

Merged

overmyheadandbody pushed a commit that referenced this pull request Mar 21, 2024

MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951)

23f725c

* pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

overmyheadandbody pushed a commit that referenced this pull request Apr 8, 2024

MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951)

55dd878

* pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

overmyheadandbody pushed a commit to overmyheadandbody/milo that referenced this pull request Apr 29, 2024

MWPW-141020: [Project PEP] Implement Analytics Enablement (adobecom#1951

141d9b6

) * pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

overmyheadandbody pushed a commit that referenced this pull request Apr 29, 2024

MWPW-141020: [Project PEP] Implement Analytics Enablement (#1951)

8b96cf5

* pep analytics * hotfix * hotfix * hotfix * removed capitalization from analytics label

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-141020: [Project PEP] Implement Analytics Enablement #1951

MWPW-141020: [Project PEP] Implement Analytics Enablement #1951

robert-bogos commented Mar 4, 2024 •

edited

Loading

aem-code-sync bot commented Mar 4, 2024 •

edited

Loading

codecov bot commented Mar 4, 2024 •

edited

Loading

overmyheadandbody left a comment

overmyheadandbody left a comment

SilviuLCF commented Mar 7, 2024 •

edited

Loading

honstar commented Mar 19, 2024

overmyheadandbody commented Mar 20, 2024

MWPW-141020: [Project PEP] Implement Analytics Enablement #1951

MWPW-141020: [Project PEP] Implement Analytics Enablement #1951

Conversation

robert-bogos commented Mar 4, 2024 • edited Loading

Description

Related Issue

Testing instructions

Screenshots

Test URLs

aem-code-sync bot commented Mar 4, 2024 • edited Loading

codecov bot commented Mar 4, 2024 • edited Loading

Codecov Report

overmyheadandbody left a comment

Choose a reason for hiding this comment

overmyheadandbody left a comment

Choose a reason for hiding this comment

SilviuLCF commented Mar 7, 2024 • edited Loading

honstar commented Mar 19, 2024

overmyheadandbody commented Mar 20, 2024

robert-bogos commented Mar 4, 2024 •

edited

Loading

aem-code-sync bot commented Mar 4, 2024 •

edited

Loading

codecov bot commented Mar 4, 2024 •

edited

Loading

SilviuLCF commented Mar 7, 2024 •

edited

Loading