[Release] Stage to Main #2043
Merged
[Release] Stage to Main #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
…t automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
There's a potential CSO lurking
…ements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
…op resolutions (#2016) fixed CSS selector commerce-frame section and fragment
* [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
* Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>
* Add support for bold as header if no header * Add tracking to modal close button * separate branches * moving if on strong or B --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
[MWPW-144112] point to prod end-point
…1966) * fix if svg is located in fragments folder * update to handle any file that is not a fragment * unit test * better placement * update existing file reference no idea how this was working with the incorrect reference * add carve out for mp4 Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached * save match result so I do not have to match twice * update nameSplit to hasExtension per Slack request * update hasExtension to use include instead of length --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
* stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
…ity (#2032) * MWPW-139939 - Support for quiz state in local storage (#1956) * MWPW-139939 - Support for quiz state in local storage * Renders the quiz at any point as captured in local storage Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939) * fix for no stored-quiz-state * remove stored quiz data when advancing to the next quiz step via handleOnNextClick() * stored quiz state unit tests * MWPW-143799 - Quiz Accessibility Refinement (#2004) * Add id to the h1 * set role and aria-labelledby on the option container * swap to role-checkbox and aria-checked for option buttons * use disabled instead of tabindex -1 Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799)
Blainegunn
requested review from
chrischrischris,
colloyd,
sabyamon,
fullcolorcoder,
JackySun9 and
elaineskpt
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 96.30% 96.36% +0.06%
==========================================
Files 166 166
Lines 42314 42531 +217
==========================================
+ Hits 40749 40986 +237
+ Misses 1565 1545 -20 ☔ View full report in Codecov by Sentry. |
JackySun9
added
needs-verification
Blainegunn
added
the
Ready for Main
|
@Blainegunn This PR is showing it is out of sync with base branch .. could you confirm if it is ready for verification as this might be out of date? |
Merged
|
Just as an FYI, #1951 is NOT part of this batch, it was mistakenly merged to a feature branch. I've crossed it off the description. |
|
Validation done from CC side, details are added in https://jira.corp.adobe.com/browse/MWPW-144601 |
aishwaryamathuria
approved these changes
Mar 20, 2024
Roycethan
approved these changes
Mar 20, 2024
JackySun9
approved these changes
Mar 20, 2024
Dli3
approved these changes
Mar 20, 2024
JFernandezAdobe
approved these changes
Mar 20, 2024
Blainegunn
added a commit
that referenced
this pull request
Mar 20, 2024
This reverts commit b19efef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWPW-141020: [Project PEP] Implement Analytics Enablement #1951