[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma #1992

vgoodric · 2024-03-12T06:37:02Z

Detailed Description: the MEP parameter supports multiple manifests by using a comma to separate the manifest/experience pairs. This delimiter was chosen before the MEP manifests supported commas in the column names. These 2 features collide when trying to spoof a column containing a comma.

................................
URL: https://main--cc--adobecom.hlx.page/products/premiere?mep=%2Fproducts%2Fpremiere.json--cc-all-apps-any%2C+premiere-any%2C%2Fcc-shared%2Ffragments%2Fpromos%2F2024%2Famericas%2Fcci-all-apps-q1%2Fcci-all-apps-q1.json--all
................................
Steps to Reproduce:

Go to the link above
Use the MEP button to preview an experience with a comma
Check the MEP button panel again.

Expected Results: The experience you previously selected will be chosen
................................
Actual Results: The experience you previously selected will not be chosen

Solution, switch from using a comma to separate manifest/experience pairs and use 3 dashes instead.

Resolves: MWPW-143067

Test URLs:

aem-code-sync · 2024-03-12T06:37:05Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

f9a0f82 ✅ (latest)
e8cd302 ✅
1c3e0ae ✅

aem-code-sync · 2024-03-12T06:37:26Z

Page	Scores	Audits	Google
/drafts/vgoodrich/fragments/2024/q2/meppreviewdelimiter/?martech=off

codecov · 2024-03-12T06:39:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (330b0ce) to head (f9a0f82).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           mepmanifestorder2    #1992      +/-   ##
=====================================================
- Coverage              96.31%   96.30%   -0.01%     
=====================================================
  Files                    165      165              
  Lines                  42404    42404              
=====================================================
- Hits                   40843    40839       -4     
- Misses                  1561     1565       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mokimo

I assume those parameters are authored? Is there any backwards compatibility that needs to be considered?

mokimo · 2024-03-12T11:51:39Z

The PSI check is failing, would be great to get that green. There's some guidance here (aka just restart tests or use published hlx.live pages)

overmyheadandbody · 2024-03-12T15:10:45Z

libs/features/personalization/personalization.js

@@ -606,6 +606,7 @@ function compareExecutionOrder(a, b) {
 export function cleanAndSortManifestList(manifests) {
  const manifestObj = {};
  manifests.forEach((manifest) => {
+    if (!manifest) return;


What's the use-case here? Can manifests contain falsy values?

yes, my sample page was producing an array with a length of 3 (2 manifests and an "empty" manifest). Hadn't seen it before, but decided to add this line to protect from other pages having the same issue.

vgoodric · 2024-03-12T17:48:29Z

I assume those parameters are authored? Is there any backwards compatibility that needs to be considered?

@mokimo the preview link feature is considered internal only. I can't think of a way to make this backwards compatible if a person has an "old link". But the preview button makes it very easy to generate a new link, so this should not be much of a hardship.

vgoodric · 2024-03-12T17:51:04Z

The PSI check is failing, would be great to get that green. There's some guidance here (aka just restart tests or use published hlx.live pages)

Because almost all of my PR's involve MEP, I can't ever seem to pass the psi-check.

* new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests

* stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. * MWPW-144026 Update Twitter Icon to X (#2030) * Add support for bold as header if no header (#1997) * Add support for bold as header if no header * Add tracking to modal close button * separate branches * moving if on strong or B --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * [MWPW-144112] send-to-caas: point to prod end-point (#1995) [MWPW-144112] point to prod end-point * [MILO] Allow svg or media files to be located in a fragments folder (#1966) * fix if svg is located in fragments folder * update to handle any file that is not a fragment * unit test * better placement * update existing file reference no idea how this was working with the incorrect reference * add carve out for mp4 Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached * save match result so I do not have to match twice * update nameSplit to hasExtension per Slack request * update hasExtension to use include instead of length --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Consolidate MEP PR's for stage (#1975) * stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * UAR integration - Quiz Sync for state in local storage and accessibility (#2032) * MWPW-139939 - Support for quiz state in local storage (#1956) * MWPW-139939 - Support for quiz state in local storage * Renders the quiz at any point as captured in local storage Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939) * fix for no stored-quiz-state * remove stored quiz data when advancing to the next quiz step via handleOnNextClick() * stored quiz state unit tests * MWPW-143799 - Quiz Accessibility Refinement (#2004) * Add id to the h1 * set role and aria-labelledby on the option container * swap to role-checkbox and aria-checked for option buttons * use disabled instead of tabindex -1 Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799) --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com> Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com>

change delimiter to ---

1c3e0ae

vgoodric added the trivial PR doesn't require E2E testing by a reviewer label Mar 12, 2024

vgoodric requested a review from a team as a code owner March 12, 2024 06:37

vgoodric requested review from 3ch023 and chrischrischris March 12, 2024 06:37

update unit tests

e8cd302

aem-code-sync bot temporarily deployed to meppreviewdelimiter March 12, 2024 07:01 Inactive

mokimo approved these changes Mar 12, 2024

View reviewed changes

chrischrischris approved these changes Mar 12, 2024

View reviewed changes

overmyheadandbody approved these changes Mar 12, 2024

View reviewed changes

vgoodric mentioned this pull request Mar 13, 2024

Consolidate MEP PR's for stage #1975

Merged

Merge branch 'mepmanifestorder2' into meppreviewdelimiter

f9a0f82

aem-code-sync bot deployed to meppreviewdelimiter March 15, 2024 05:08 View deployment

vgoodric merged commit ab71b35 into mepmanifestorder2 Mar 15, 2024
11 of 12 checks passed

vgoodric deleted the meppreviewdelimiter branch March 15, 2024 05:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma #1992

[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma #1992

vgoodric commented Mar 12, 2024

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

codecov bot commented Mar 12, 2024 •

edited

Loading

mokimo left a comment

mokimo commented Mar 12, 2024

overmyheadandbody Mar 12, 2024

vgoodric Mar 12, 2024

vgoodric commented Mar 12, 2024

vgoodric commented Mar 12, 2024

[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma #1992

[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma #1992

Conversation

vgoodric commented Mar 12, 2024

aem-code-sync bot commented Mar 12, 2024 • edited Loading

aem-code-sync bot commented Mar 12, 2024 • edited Loading

codecov bot commented Mar 12, 2024 • edited Loading

Codecov Report

mokimo left a comment

Choose a reason for hiding this comment

mokimo commented Mar 12, 2024

overmyheadandbody Mar 12, 2024

Choose a reason for hiding this comment

vgoodric Mar 12, 2024

Choose a reason for hiding this comment

vgoodric commented Mar 12, 2024

vgoodric commented Mar 12, 2024

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

aem-code-sync bot commented Mar 12, 2024 •

edited

Loading

codecov bot commented Mar 12, 2024 •

edited

Loading