MWPW-142894: fragments can lead to invalid html #1937

robert-bogos · 2024-02-28T09:47:46Z

Description

This PR fixes the bug where resolving fragments can lead to invalid HTML

Related Issue

Resolves: MWPW-141039

Testing instructions

change web-test-runner.config.mjs by adding files: ['./test/blocks/fragment/fragment.test.js'], to the default exported json (this will help target the fragment.test.js for tests)
run npm run test:file:watch
the HTML difference can be seen by removing the code added in this PR for fragment.js and running the test again

Test URLs

Acrobat:

BACOM:

CC:

Homepage:

Blog:

Milo:

test/blocks/fragment/mocks/fragments/frag-p.plain.html

overmyheadandbody

As @mokimo mentioned earlier, let's remove the logic from the Global Navigation utilities, if we're expanding it to the fragments file.

mokimo · 2024-02-28T15:03:26Z

There also seem to be a few related unit tests failing

codecov · 2024-02-29T06:07:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (33d5746) to head (9414474).

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #1937   +/-   ##
=======================================
  Coverage   96.30%   96.31%           
=======================================
  Files         165      165           
  Lines       42232    42232           
=======================================
+ Hits        40671    40674    +3     
+ Misses       1561     1558    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robert-bogos · 2024-02-29T06:09:22Z

There also seem to be a few related unit tests failing

Fixed them 👍 Also an unaddressed use case came to the surface due to those failing unit tests. I made the adjustments in fragment.js

libs/blocks/fragment/fragment.js

mokimo

Nice 👍 This leads to very unexpected behavior - so it's good to have this fixed in the right spot

libs/blocks/fragment/fragment.js

aem-code-sync · 2024-03-01T15:13:49Z

Page	Scores	Audits	Google
/drafts/rbogos/page-default?martech=off

libs/blocks/fragment/fragment.js

SilviuLCF

QA verified https://jira.corp.adobe.com/browse/MWPW-141039

MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (adobecom#2005) MWPW-143673: Load Milo fragment modals from co links adobecom#1972 MWPW-142894: fragments can lead to invalid html adobecom#1937 High Priority Caas-Marquee: Fixes integration with martech.js issues adobecom#2003 MWPW-143591 Fix Contextual Search Duplicates adobecom#1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing adobecom#2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (adobecom#2010) * Update martech.main.standard.min.js (adobecom#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. * MWPW-144026 Update Twitter Icon to X (#2030) * Add support for bold as header if no header (#1997) * Add support for bold as header if no header * Add tracking to modal close button * separate branches * moving if on strong or B --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * [MWPW-144112] send-to-caas: point to prod end-point (#1995) [MWPW-144112] point to prod end-point * [MILO] Allow svg or media files to be located in a fragments folder (#1966) * fix if svg is located in fragments folder * update to handle any file that is not a fragment * unit test * better placement * update existing file reference no idea how this was working with the incorrect reference * add carve out for mp4 Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached * save match result so I do not have to match twice * update nameSplit to hasExtension per Slack request * update hasExtension to use include instead of length --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Consolidate MEP PR's for stage (#1975) * stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * UAR integration - Quiz Sync for state in local storage and accessibility (#2032) * MWPW-139939 - Support for quiz state in local storage (#1956) * MWPW-139939 - Support for quiz state in local storage * Renders the quiz at any point as captured in local storage Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939) * fix for no stored-quiz-state * remove stored quiz data when advancing to the next quiz step via handleOnNextClick() * stored quiz state unit tests * MWPW-143799 - Quiz Accessibility Refinement (#2004) * Add id to the h1 * set role and aria-labelledby on the option container * swap to role-checkbox and aria-checked for option buttons * use disabled instead of tabindex -1 Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799) --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com> Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com>

fix for fragments leading to invalid html

045d170

robert-bogos added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Feb 28, 2024

robert-bogos requested review from narcis-radu, overmyheadandbody and mokimo February 28, 2024 09:47

robert-bogos self-assigned this Feb 28, 2024

mokimo reviewed Feb 28, 2024

View reviewed changes

test/blocks/fragment/mocks/fragments/frag-p.plain.html Outdated Show resolved Hide resolved

overmyheadandbody reviewed Feb 28, 2024

View reviewed changes

robert-bogos added 2 commits February 28, 2024 16:33

removed fragments fix from gnav

fa1429d

added EOF

dda67d5

hotfix

ce6b312

removed empty line

3ac4024

robert-bogos requested review from overmyheadandbody and mokimo February 29, 2024 06:14

mokimo reviewed Feb 29, 2024

View reviewed changes

libs/blocks/fragment/fragment.js Outdated Show resolved Hide resolved

mokimo approved these changes Feb 29, 2024

View reviewed changes

overmyheadandbody reviewed Feb 29, 2024

View reviewed changes

libs/blocks/fragment/fragment.js Outdated Show resolved Hide resolved

robert-bogos added 2 commits March 1, 2024 07:49

hotfix

c8243a4

transfer attributes on replacing fragment parent

2584d04

robert-bogos requested a review from overmyheadandbody March 1, 2024 07:59

refactor

6ee176d

adobecom deleted a comment from aem-code-sync bot Mar 1, 2024

mokimo approved these changes Mar 1, 2024

View reviewed changes

overmyheadandbody approved these changes Mar 1, 2024

View reviewed changes

narcis-radu approved these changes Mar 1, 2024

View reviewed changes

libs/blocks/fragment/fragment.js Outdated Show resolved Hide resolved

Blainegunn changed the base branch from main to stage March 1, 2024 23:01

hotfix

26f45ed

robert-bogos requested a review from SilviuLCF March 4, 2024 09:40

robert-bogos assigned SilviuLCF Mar 4, 2024

SilviuLCF approved these changes Mar 5, 2024

View reviewed changes

SilviuLCF added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 5, 2024

Merge branch 'stage' into mwpw-141039-fragments-invalid-html

9414474

SilviuLCF added the Ready for Stage label Mar 13, 2024

Blainegunn merged commit 9df680e into adobecom:stage Mar 13, 2024
13 of 14 checks passed

Blainegunn mentioned this pull request Mar 13, 2024

[Release] Stage to Main #2005

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-142894: fragments can lead to invalid html #1937

MWPW-142894: fragments can lead to invalid html #1937

robert-bogos commented Feb 28, 2024

overmyheadandbody left a comment

mokimo commented Feb 28, 2024

codecov bot commented Feb 29, 2024 •

edited

Loading

robert-bogos commented Feb 29, 2024

mokimo left a comment

aem-code-sync bot commented Mar 1, 2024 •

edited

Loading

SilviuLCF left a comment

MWPW-142894: fragments can lead to invalid html #1937

MWPW-142894: fragments can lead to invalid html #1937

Conversation

robert-bogos commented Feb 28, 2024

Description

Related Issue

Testing instructions

Test URLs

overmyheadandbody left a comment

Choose a reason for hiding this comment

mokimo commented Feb 28, 2024

codecov bot commented Feb 29, 2024 • edited Loading

Codecov Report

robert-bogos commented Feb 29, 2024

mokimo left a comment

Choose a reason for hiding this comment

aem-code-sync bot commented Mar 1, 2024 • edited Loading

SilviuLCF left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 29, 2024 •

edited

Loading

aem-code-sync bot commented Mar 1, 2024 •

edited

Loading