MWPW-143673: Load Milo fragment modals from co links #1972

yesil · 2024-03-07T13:00:24Z

This PR prepares the ground for Milo native TWP modals to be triggered by merch checkout links.

Includes:

Test URLs:

Working test URLs (due to CSP):

https://main--cc--adobecom.hlx.page/drafts/ilyas/checkout-links?martech=off&milolibs=mwpw-143673--milo--yesil

aem-code-sync · 2024-03-07T13:00:50Z

Page	Scores	Audits	Google
/drafts/ilyas/checkout-links?martech=off

codecov · 2024-03-08T14:57:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (33d5746) to head (56d956d).

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #1972      +/-   ##
==========================================
+ Coverage   96.30%   96.32%   +0.01%     
==========================================
  Files         165      165              
  Lines       42232    42264      +32     
==========================================
+ Hits        40671    40710      +39     
+ Misses       1561     1554       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vladen

@yesil as for me, your code is beautiful ;)

mirafedas · 2024-03-12T14:19:01Z

libs/blocks/modal/modal.css

-.dialog-modal.commerce-frame .fragment,
-.dialog-modal.commerce-frame .section {
+.dialog-modal.commerce-frame > .fragment,
+.dialog-modal.commerce-frame > .section {
  height: 100vh;


It is better to move this rule on line 206 (into the @media (max-width: 1200px) {}), otherwise it is applied on the desktop and makes the modal content height too big (adds a scroll). I added this change in this PR, but not sure which one will be merged first :)

@mirafedas
the > in the rule is still needed because otherwise they apply to all the nested fragments and breaks the page.
Since you have an iframe you didn't notice it.
Can you add > in yours?

Thanks for info, I didn't know, I'll add it

MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* [Release] Stage to Main (adobecom#2005) MWPW-143673: Load Milo fragment modals from co links adobecom#1972 MWPW-142894: fragments can lead to invalid html adobecom#1937 High Priority Caas-Marquee: Fixes integration with martech.js issues adobecom#2003 MWPW-143591 Fix Contextual Search Duplicates adobecom#1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing adobecom#2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (adobecom#2010) * Update martech.main.standard.min.js (adobecom#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local>

* MWPW-143648 - [Action Item] Fix float icon position (#1957) * display main image block and add inline flex to floated icon * revert inline flex rull on floated icon --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142798 + MWPW-142872: Made the height-fit-content class to be set automatically (#1946) fixed height auto adjustment and iframe styles in modal Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Fix for commerce modal height (#2014) There's a potential CSO lurking * [MWPW-144516] Handle cross cloud menu block error (#2006) * fix(MWPW-142248): Accessibility for carousels containing focusable elements. (#1901) * MWPW-142248 * fixed linting errors * revert package.json * revert package_lock.json * Accessibility for the show-x variants of carousel * test cases for code coverage --------- Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-144575: Modal-Iframe for apps-whats-included is broken for Desktop resolutions (#2016) fixed CSS selector commerce-frame section and fragment * Sync stage with main (#2025) * [Release] Stage to Main (#2005) MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * [Release] Stage to Main (#2010) * Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * fix merge empty line --------- Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> * remove extra line * MWPW-144575: fix for the modal duplication (#2021) added checking to not create a modal when it is already present in DOM Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> * [MWPW-137148] [PERFORMANCE] Load IMS from the same domain (#1996) * Host imslib from milo libs/deps * Fix formatting * Minor script cleanup * wp * Serve ims, launch & launch development locally. Rewrite the workflow * Remove launch dependency for now --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-142003: Mini Compare Chart Mobile styling (#1989) Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * MWPW-143202 firefox gnav not appearing bug (#1969) * try to catch error * test without breaking things * catch akamai failure * add try catch * attempt 2 to catch jsonp failure * cleanup * fix geo2 source * test using proper fetch * MWPW-143202 remove old jsonp request * MWPW-143202 catch case if resp is not ok * MWPW-143202 prevent caching of geo2 request --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Excluding modals from Active link check (#1942) * Fix: Excluding modals from Active link check --------- Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> * [MWPW-144602] Ensure DNT functionality in top nav (#2020) * Revert "MWPW-142003: Mini Compare Chart Mobile styling" (#2041) Revert "MWPW-142003: Mini Compare Chart Mobile styling (#1989)" This reverts commit 944ae19. * MWPW-144026 Update Twitter Icon to X (#2030) * Add support for bold as header if no header (#1997) * Add support for bold as header if no header * Add tracking to modal close button * separate branches * moving if on strong or B --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * [MWPW-144112] send-to-caas: point to prod end-point (#1995) [MWPW-144112] point to prod end-point * [MILO] Allow svg or media files to be located in a fragments folder (#1966) * fix if svg is located in fragments folder * update to handle any file that is not a fragment * unit test * better placement * update existing file reference no idea how this was working with the incorrect reference * add carve out for mp4 Noticed that there is code in this if statement for mp4 in the fragments folder that can't be reached * save match result so I do not have to match twice * update nameSplit to hasExtension per Slack request * update hasExtension to use include instead of length --------- Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * Consolidate MEP PR's for stage (#1975) * stash * start retro support (need to adjust replacefragment) * save progress * progress * stash * solid state * reverse mep preview check * update file for insertScript * organized unit test files * unit tests working * remove file added by override * add coverage to unit test * PR comments * use "section" to mean "section1" * no longer need to pass mep to handleFragmentCommand * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add replace action with fragment selector not on page * moving fragment that's not page unit test * [MILO][MEP] Update Manifest Type and Manifest Ordering v2 (#1980) * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * stop loading disabled promos * update unit test * only download disabled manifests if needed * [MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma (#1992) * change delimiter to --- * update unit tests * Deconflicting for MWPW-136727 MEP: Support for simplified selectors (#1959) * WIP * Add tests * stash * stash * stash * merge select functions * unit tests fixed * fix for test or promo type * create unit test file * fix unit test error * unit tests * improve merge of duplicate manifests * fix merge of Target with fresh manifest, add unit test * new branch to separate my updates from others * export matchGlob * see if removing matchGlob fixes unit test * found unit test issue * stash * unit test repair * increase coverage * merge conflicts * remove duplicate from merge * remove another duplicate from merge --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com> * more duplicates * move normalization of manifestPath to before getting variant * Unit test repair * repair utils unit test * only update path if needed * force update sample scripts * trigger try/catch --------- Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> * UAR integration - Quiz Sync for state in local storage and accessibility (#2032) * MWPW-139939 - Support for quiz state in local storage (#1956) * MWPW-139939 - Support for quiz state in local storage * Renders the quiz at any point as captured in local storage Resolves: [MWPW-139939](https://jira.corp.adobe.com/browse/MWPW-139939) * fix for no stored-quiz-state * remove stored quiz data when advancing to the next quiz step via handleOnNextClick() * stored quiz state unit tests * MWPW-143799 - Quiz Accessibility Refinement (#2004) * Add id to the h1 * set role and aria-labelledby on the option container * swap to role-checkbox and aria-checked for option buttons * use disabled instead of tabindex -1 Resolves: [MWPW-143799](https://jira.corp.adobe.com/browse/MWPW-143799) --------- Co-authored-by: Sean Archibeque <sean.archibeque@gmail.com> Co-authored-by: Mira Fedas <30750556+mirafedas@users.noreply.github.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> Co-authored-by: sharath-kannan <138484653+sharath-kannan@users.noreply.github.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com> Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com> Co-authored-by: Bandana Laishram <blaishram@Bandanas-MacBook-Pro.local> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: jedjedjedM <93785811+jedjedjedM@users.noreply.github.com> Co-authored-by: vivgoodrich <vivian.goodrich@gmail.com> Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com> Co-authored-by: Victor Hargrave <vhargrave@adobe.com>

MWPW-143673: Load Milo fragment modals from co links

8a1d26f

yesil requested a review from a team as a code owner March 7, 2024 13:00

yesil added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer labels Mar 7, 2024

yesil added 8 commits March 7, 2024 17:53

remove unused css

205bc17

force .page instead of .live for co link configs

a3d5ba2

force .page instead of .live for co link configs

7c231d0

force .page instead of .live for co link configs

fe58171

Merge branch 'stage' into MWPW-143673

c30b1da

update price literals URL

bf11106

fix tests

c074ecc

fix broken tests

f9fd110

yesil added 8 commits March 11, 2024 12:33

Merge branch 'stage' into MWPW-143673

709b622

update style

8b952cf

consume latest commerce version

d91938b

align response values

633a008

Merge branch 'stage' into MWPW-143673

1650ed9

align response values

e481595

align response values

7e714d1

hide fragment during loadArea

1e943a1

vladen approved these changes Mar 12, 2024

View reviewed changes

mirafedas reviewed Mar 12, 2024

View reviewed changes

mirafedas approved these changes Mar 12, 2024

View reviewed changes

yesil added 4 commits March 13, 2024 08:53

wip

52edd47

update commerce api

03ae33f

MWPW-143673: Load Milo fragment modals from co links

7338d29

Merge branch 'stage' into MWPW-143673

dcd9c7c

yesil added 4 commits March 13, 2024 11:30

update commerce lib

4c55cf8

ignore untestable line from codecov

cc60f6d

ignore untestable line from codecov

63b9215

remove js.map file

56d956d

mirafedas approved these changes Mar 13, 2024

View reviewed changes

afmicka added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Mar 13, 2024

yesil added the Ready for Stage label Mar 13, 2024

3ch023 approved these changes Mar 13, 2024

View reviewed changes

Blainegunn merged commit 40670a4 into adobecom:stage Mar 13, 2024
17 checks passed

Blainegunn mentioned this pull request Mar 13, 2024

[Release] Stage to Main #2005

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-143673: Load Milo fragment modals from co links #1972

MWPW-143673: Load Milo fragment modals from co links #1972

yesil commented Mar 7, 2024 •

edited

Loading

aem-code-sync bot commented Mar 7, 2024 •

edited

Loading

codecov bot commented Mar 8, 2024 •

edited

Loading

vladen left a comment

mirafedas Mar 12, 2024

yesil Mar 12, 2024

mirafedas Mar 12, 2024

MWPW-143673: Load Milo fragment modals from co links #1972

MWPW-143673: Load Milo fragment modals from co links #1972

Conversation

yesil commented Mar 7, 2024 • edited Loading

aem-code-sync bot commented Mar 7, 2024 • edited Loading

codecov bot commented Mar 8, 2024 • edited Loading

Codecov Report

vladen left a comment

Choose a reason for hiding this comment

mirafedas Mar 12, 2024

Choose a reason for hiding this comment

yesil Mar 12, 2024

Choose a reason for hiding this comment

mirafedas Mar 12, 2024

Choose a reason for hiding this comment

yesil commented Mar 7, 2024 •

edited

Loading

aem-code-sync bot commented Mar 7, 2024 •

edited

Loading

codecov bot commented Mar 8, 2024 •

edited

Loading