Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2146

Merged
merged 8 commits into from
Apr 16, 2024
Merged

[Release] Stage to Main #2146

merged 8 commits into from
Apr 16, 2024

Conversation

yesil and others added 6 commits April 15, 2024 13:40
* Update the imslib sync workflow

* Formatting improvements
* MWPW-136885: Merch Card Accessibility

* addressed review comment

* Update merch-card.js
* MWPW-144811: custom params in co links

* fix test

* remove empty line

* update co params

* update commerce api

with the latest co builder from pandora/tacocat

* update tests

---------

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Revert "MWPW-136885: Merch Card Accessibility (#2078)"

This reverts commit 3cc1aca.
…#2140)

* MWPW-146491 Increase Target timeout again and improve analytics

* remove duplicate analytic

* simplify timeout number

* update math again

* define sendAnalytics event

* improvements with Chris
@Blainegunn Blainegunn added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Apr 15, 2024
@Blainegunn Blainegunn requested review from a team April 15, 2024 17:25
@Blainegunn Blainegunn requested review from a team as code owners April 15, 2024 17:25
Copy link
Contributor

aem-code-sync bot commented Apr 15, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (c262026) to head (28dc0d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   96.35%   96.64%   +0.28%     
==========================================
  Files         166      165       -1     
  Lines       43645    43484     -161     
==========================================
- Hits        42056    42025      -31     
+ Misses       1589     1459     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/global-link-styles April 15, 2024 21:06 Inactive
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@robert-bogos robert-bogos merged commit b74610d into main Apr 16, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.