Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #57

Closed
wants to merge 37 commits into from
Closed

[Release] Stage to Main #57

wants to merge 37 commits into from

Conversation

github-actions[bot]
Copy link

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

robert-bogos and others added 30 commits April 16, 2024 14:12
* MWPW-146352 fix georouting dropdown on ios (adobecom#2143)

* MWPW-146491 Fast follow to add timeout value (adobecom#2155)

add timeout value

---------

Co-authored-by: Victor Hargrave <115231412+vhargrave@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
…ad of performance (adobecom#2163)

* Do not use Error when timing out

* revert and lint fix

---------

Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com>
…em> authoring (adobecom#2059)

* Support button.fill w/ <strong><em> authoring

* Cleaned up the logic for fill button so dom is flat and accounts for nested authoring conditions

* linting err

* fixed media test
…dobecom#2070)

* Check for block content and use as header if exists, updated twitter icon ref

* Refactored to allow for authoring icon discression

* share.test for new custom title, refactored so .inline doesn't have title support

* remove test console

* linting

* eslint adjust better readability
…e icons" (adobecom#2172)

Revert "MWPW-142590 - [Share] enhancement - ability to edit text above icons …"

This reverts commit 9895190.
…cards (adobecom#2167)

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
…izontal cards" (adobecom#2177)

Revert "[MWPW-146756] Add support for RTL in aside notifications, horizontal …"

This reverts commit e71b33d.
…ards"" (adobecom#2178)

Revert "Revert "[MWPW-146756] Add support for RTL in aside notifications, hor…"

This reverts commit 76bcdbc.
Fixes multiple Mini Compare Chart card alignment and spacing issues.

Resolves: MWPW-142003

Note: Alignment across cards will show broken in test URL because prices are not resolved due to CORS policy. To properly test alignment, please use this URL: https://main--cc--adobecom.hlx.page/drafts/axel/mini-compare-chart-edgecase?milolibs=MWPW-142003--milo--axelcureno

Test URLs:

Before: https://main--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off
After: https://mwpw-142003--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off

Co-authored-by: ilyas Stéphane Türkben <isturkben@gmail.com>
…obecom#2123)

* Closes the global nav expanded wrapper in non desktop viewports when the user interacts with the universal nav (Notifications, app switcher, and profile/sign in button)

* We no longer use element.click

* made toggleMenuMobile a method of the Gnav class

* Extracted the toggle expanded check into its own function

* a little cleanup
…ices" (adobecom#2182)

Revert "MWPW-146129 App Launcher overlaps the menu in Unav in the devices (#2…"

This reverts commit 743ce09.
…in Unav in the devices (adobecom#2184)

* Closes the global nav expanded wrapper in non desktop viewports when the user interacts with the universal nav (Notifications, app switcher, and profile/sign in button)

* We no longer use element.click

* made toggleMenuMobile a method of the Gnav class

* Extracted the toggle expanded check into its own function

* a little cleanup
…dobecom#2152)

* MWPW-135821 introduce custom action

- and inaugurating first custom action for replacing cards in collection

* MWPW-135821 use prefix in selector

* MWPW-135821 adding preview data

---------

Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
…2098)

* MWPW-144549 CTA alignment for Text, Icon, and Media Blocks

* redo in flex

* tests and renaming

* icon cleanup

* test cleanup

* lint cleanup

* cr rename ctas

* supplemental text and consistent variable names

* qa - fix icon block mobile padding

* qa - exclude qr code

* icon bio cta

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Elan Bartholomew <79870969+elan-tbx@users.noreply.github.com>
robert-bogos and others added 7 commits April 25, 2024 13:25
* updated eslint-plugin-compat

* added TODOs

* hotfix
…dobecom#2207)

Revert "MWPW-144549 CTA alignment for Text, Icon, and Media Blocks (adobecom#2098)"

This reverts commit 95d6ad6.
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* RTL padding merch icon

* dep update
* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.