Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden preflight link checking #2169

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Harden preflight link checking #2169

merged 1 commit into from
Apr 25, 2024

Conversation

rgclayton
Copy link
Contributor

@rgclayton rgclayton commented Apr 19, 2024 •
edited
Loading

  • Filter out empty hrefs before sending to spidy.
  • Harden link check to be more robust against Spidy API.
  • Update link check language.
  • Better onboarding support.
    • Adds fallbacks if .milo/config has not been added.
  • Fix for missing Word doc reference, under general tab.

Resolves: MWPW-146695

Test URLs:

Bacom Test URLs

CC Test URLs

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 19, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/rclayton/test-template?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rgclayton rgclayton added bug Something isn't working trivial PR doesn't require E2E testing by a reviewer labels Apr 19, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (d82fdcc) to head (38018fe).
Report is 23 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #2169      +/-   ##
==========================================
+ Coverage   96.63%   96.65%   +0.01%     
==========================================
  Files         165      165              
  Lines       43484    43523      +39     
==========================================
+ Hits        42022    42068      +46     
+ Misses       1462     1455       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Filter out empty hrefs before sending to spidy.
38018fe 
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)
@rgclayton rgclayton force-pushed the preflight-link-check-harden branch from 2bca8eb to 38018fe Compare April 19, 2024 23:57
@github-actions GitHub Actions
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@Ruchika4 Ruchika4 merged commit 8ee620d into stage Apr 25, 2024
14 checks passed
@Ruchika4 Ruchika4 deleted the preflight-link-check-harden branch April 25, 2024 17:32
@Ruchika4 Ruchika4 mentioned this pull request Apr 25, 2024
Merged
vhargrave pushed a commit that referenced this pull request Apr 29, 2024
@Ruchika4 @narcis-radu
@Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier
[Release] Stage to Main (#2208)
7f196f5 
* Update code owners for feds (#2194)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Harden preflight link checking (#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-146755: RTL merch icon padding (#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
Blainegunn added a commit that referenced this pull request Apr 29, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier
MWPW-137282 - Action item block layout options (#1501)
b7e8900 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (#2208)

* Update code owners for feds (#2194)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Harden preflight link checking (#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-146755: RTL merch icon padding (#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

---------

Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
f1158ec 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

---------

Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@rgclayton @mokimo
Harden preflight link checking (adobecom#2169)
1257a1d 
* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
fc54e9a 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

---------

Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
mokimo pushed a commit to mokimo/milo that referenced this pull request Apr 30, 2024
@Sartxi @Ruchika4
@narcis-radu @Blainegunn @robert-bogos @rgclayton @Axelcureno @npeltier @mokimo
MWPW-137282 - Action item block layout options (adobecom#1501)
8fb330f 
* actions scroller center & section grid center

* update scroller test to cover all code branches

* update test mock to avoid nav test

* put back sticky and center styles

* [Release] Stage to Main (adobecom#2208)

* Update code owners for feds (adobecom#2194)

Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* Harden preflight link checking (adobecom#2169)

* Filter out empty `hrefs` before sending to spidy.
* Harden link check to be more robust against Spidy API.
* Update link check language.
* Better onboarding support.
  * Adds fallbacks if `.milo/config` has not been added.
* Fix for missing Word doc reference, under general tab.

Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695)

Co-authored-by: Ryan Clayton <rclayton@adobe.com>

* MWPW-146755: RTL merch icon padding (adobecom#2162)

* RTL padding merch icon

* dep update

* MWPW-146001 parallelize literals call (adobecom#2187)

* MWPW-146001 parallelize literals call

* MWPW-146001 move promise to the function

* MWPW-146001 fix commerce library

* MWPW-146001 update literals endpoint

* MWPW-146001 fixing commerce ut

---------

Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

---------

Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com>
Co-authored-by: Narcis Radu <github@narcisradu.ro>
Co-authored-by: Blaine Gunn <Blainegunn@gmail.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Co-authored-by: Ryan Clayton <rclayton@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Closed
@mokimo mokimo mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auniverseaway auniverseaway auniverseaway approved these changes

@Sartxi Sartxi Sartxi approved these changes

@chrischrischris chrischrischris Awaiting requested review from chrischrischris

@ryanmparrish ryanmparrish Awaiting requested review from ryanmparrish

@Ruchika4 Ruchika4 Awaiting requested review from Ruchika4

Assignees
No one assigned
Labels
bug Something isn't working Ready for Stage trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgclayton @auniverseaway @Sartxi @Ruchika4