ENB-6995 Query Params update & sendTargetResponse function update Resubmit for #2664

[vgoodric]

• sendTargetResponse: Added Check for window._satellite and changed direct alloy call to _satellite call
• Added additional parameter as marketingtech to disable martech. The martech=off also impacts launch. So they have requested a new parameter that does the same thing in Milo as martech=off but does not impact their code.

Resolves: ENB-6995

Test URLs: https://www.adobe.com/products/photoshop.html?marketingtech=off

Psi-check: https://martechteamupdates--milo--adobecom.hlx.page?marketingtech=off

Note
Currently when passing marketingtech=off page is not loading, Expected behavior is martech bootstrap should not load and page should load as it is

More Information
There are 2 changes

In Martech.js which currently resides in milo/libs/martech/ folder, we noticed there is a function named by sendTargetResponseAnalytics which has sendEvent call using window.alloy now for the requirement to disable analytics tracking we have added certain conditions in launch due to which we are able to control data collection for most of the calls, but for this function as it is directly calling window.alloy data is being sent, we would like to modify this function.

In Utils.js which resides in milo/libs/utils/ folder, there is another function named by loadMartech where there are certain condition to check if "martech=off" exists in query params or not if it exists we do not load martech.js library, we would like to add another optional parameter as "marketingtech=off" , as our main bootstrap script has this as query prams to disable analytics library completely, currently when we pass "marketingtech=off" in any adotcom pages, page seems to crash / fail to load.

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• e118a27 ✅ (latest)
• 38b6774 ✅
• 6ae09a3 ✅

[aem-code-sync]

Page	Scores	Audits	Google
/?marketingtech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (071a858) to head (e118a27).

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2682      +/-   ##
==========================================
+ Coverage   95.74%   95.75%   +0.01%     
==========================================
  Files         172      172              
  Lines       45427    45428       +1     
==========================================
+ Hits        43492    43498       +6     
+ Misses       1935     1930       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[overmyheadandbody]

It still feels a bit weird to me that we're moving back to direct _satellite calls after we spent time porting a lot of things to alloy ones. But I'm no expert on this, so I'd just like to understand the reasoning behind it for future reference.

Who is the audience for the new query parameter? martech and marketingtech likely sound awfully alike to most people, I fear this might cause some confusion. I don't have a better naming suggestion right now, but I think this deserves a bit more thought before we commit to a new query parameter that can be used by a non-technical audience.

[theankit-sinha]

It still feels a bit weird to me that we're moving back to direct _satellite calls after we spent time porting a lot of things to alloy ones. But I'm no expert on this, so I'd just like to understand the reasoning behind it for future reference.

Who is the audience for the new query parameter? martech and marketingtech likely sound awfully alike to most people, I fear this might cause some confusion. I don't have a better naming suggestion right now, but I think this deserves a bit more thought before we commit to a new query parameter that can be used by a non-technical audience.

Hey, @overmyheadandbody
Let me just give some context - why both of these changes are requested

• For _satellite calls - we have received a new request where requester wants to do automated testing and when doing so it should not collect any data but martech and other analytical libraries and event firring should work as it is. so we have configured a dummy datatream, when this flag is passed it will just switch and send all data to dummy datastream instead of production datastream, this change is controlled via launch setup now in this code it is a direct alloy event call which we cannot control, for more information regarding this please head to this ticket [https://jira.corp.adobe.com/browse/ENB-6995]
• I understand this - Further exploring we saw that in our bootstrap code this is already implemented as marketingtech=off and its being used, to make it consistent we are adding another query parms, currently if you pass marketingtech=off in any page it seems to crash / not load

[milo-pr-merge]

Skipped 2682: "ENB-6995 Query Params update & sendTargetResponse function update Resubmit for #2664" due to file "libs/martech/martech.js" overlap. Merging will be attempted in the next batch

[milo-pr-merge]

Skipped 2682: "ENB-6995 Query Params update & sendTargetResponse function update Resubmit for #2664" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

[mokimo]

I'll merge this despite overlaps as there are a bunch of other files changing utils.js and it should be safe to include.