MWPW-154893 - [editorial-card] bugs #2656

ryanmparrish · 2024-07-30T18:03:14Z

Addressed the following bugs found for the [editorial-card]

When using an mpc type video, the aspect ratio variant media-tall wasn't displaying correctly - See GWP drafts
Smaller default margins on the authored <hr> element and adjusted the action-area to have consistent gap
Remove unused/unwanted variants - margin-top-tablet, margin-bottom-tablet, right
Exposed the variant equal-height as an author-able choice if a card does not have a footer row and still wants to have equal heights
refactors block .footer element to .card-footer to prevent naming collision. 155645

Test URLs:

GWP Drafts
https://rparrish-editorial-bugs--milo--adobecom.hlx.page/drafts/klee/test-editorial-cards
https://rparrish-editorial-bugs--milo--adobecom.hlx.page/drafts/vmorel/gold-team/editorial-card-video-test

…at as a variant

aem-code-sync · 2024-07-30T18:03:18Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

4ce6d12 ✅ (latest)
89f66c4 ✅
f3d361e ✅
4342078 ✅
3112aba ✅
c7a5396 ✅
b7f8db4 ✅
9a8260f ✅
961546b ✅
b073e7f ✅
c21a38a ✅
8ff90c6 ✅
4e6bb7a ❌
278be08 ❌

aem-code-sync · 2024-07-30T18:03:43Z

Page	Scores	Audits	Google
/drafts/klee/test-editorial-cards
/drafts/rparrish/cards/editorial-cardsmartech=off
/drafts/vmorel/gold-team/editorial-card-video-test

codecov · 2024-07-30T18:07:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (add9745) to head (4ce6d12).
Report is 31 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2656      +/-   ##
==========================================
+ Coverage   95.70%   95.75%   +0.04%     
==========================================
  Files         172      172              
  Lines       45362    45428      +66     
==========================================
+ Hits        43413    43498      +85     
+ Misses       1949     1930      -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-31T01:05:57Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/blocks/editorial-card/editorial-card.css

libs/blocks/editorial-card/editorial-card.js

libs/blocks/marquee/marquee.css

ryanmparrish · 2024-07-31T17:04:39Z

@overmyheadandbody - Thanks for the review and feedback. I have addressed the things you mentioned. Thanks

overmyheadandbody

Thanks for addressing all the feedback! Looks good overall, just two small things

libs/blocks/editorial-card/editorial-card.css

test/blocks/editorial-card/mocks/body.html

ryanmparrish · 2024-08-02T18:09:07Z

@overmyheadandbody - I fixed those last few things. Thanks

overmyheadandbody

Thanks for all the updates, looks good now!

NadiiaSokolova

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-154893 and
https://jira.corp.adobe.com/browse/MWPW-155645

robert-bogos

Looks good 👍

robert-bogos · 2024-08-06T11:25:28Z

test/blocks/editorial-card/editorial-card.test.js

+    const footer = editorialCards[3].querySelector('.card-footer');
    expect(footer).to.exist;


Nit: This could be an 1 liner.

Suggested change

const footer = editorialCards[3].querySelector('.card-footer');

expect(footer).to.exist;

expect(editorialCards[3].querySelector('.card-footer')).to.exist;

milo-pr-merge · 2024-08-06T12:17:39Z

Skipped merging 2656: MWPW-154893 - [editorial-card] bugs due to failing checks

Revert "MWPW-147867 - [marquee] support RTL for loc" (#2662) Revert "MWPW-147867 - [marquee] support RTL for loc (#2640)" This reverts commit 49df5f7. Revert "[MWPW-145131] Send locale and language code to analytics" (#2661) Revert "[MWPW-145131] Send locale and language code to analytics (#2600)" This reverts commit 04e687f. MWPW-155079 [MILO][MEP] Manifests not changing domains (#2626) * replace overridePersonalizationVariant function * Fix chaining * Move parseMepParam * add additional optional chaining operator Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * Refactor personalization.js * Remove comment * Add TargetManifestId * Remove comment * Add targetManifestId test * Refactor addMepHighlightAndTargetManifestIdGnav * Remove console.log from test * Shorten function name * Limits targetManifestId to target exp and adds missing name to manifestId * Fix test * Handle default selectedVariant issue * Mostly done * Merging in prop display update * Unit tests fixed * Add targetmanifestid to useblockcode * refactor to remove unnecessary import * Remove commented code * Removing unused functions * Update tests, not including replacePage * Shorten Function Name * move insert inline back to fragment.js * additional cleanup and unit tests * Fix adobeTargetTestId issues * add optional chaining * Update condition for addAnalyticsForUseBlockCode * Refactor to handle analytics for updatemetadata * Fix useBlockCode test * Fix merged merged test * Remove applyPers from preload fragments test * Fix martech init post-merge * Fix tests and martech merge cleanup * Dynamically import personalization.js * add 2 ignore comments * add conditional chaining * Remove mwpw-146528 temp files * MWPW-152275 Move manifest.json request up while waiting on sstats / etc. (#2608) * add preload * shorten if and and conditional chaining * run loop even if Target is off * Add nullish coalescing assignment suggestion * MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (#2616) * add default execution order * unit test * normalizePath * add normalizePath back into preload * MWPW-155568 [MILO][MEP] If MEP is completely off, mep param should still show button (#2658) don't return if param is present but empty --------- Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Mark Perry <124626043+markpadbe@users.noreply.github.com> MWPW-146030 and MWPW-143704 Add fresco-any and cc-paid-no-stock (#2657) add entitlements Attaching loadblock to window to provide alternative way of loading the script (#2660) Attaching loadblock to window MWPW-155316 - Fixing Pill Notification edge cases (#2639) * handling pill edge cases * pill edge case styles * update tests to fix coverage * correction to previous commit * updates based on PR feedback * more simplifying * adding an additional filter * style tweak * change inline size for desktop pills * revert of icon sizing * revert of ribbon revert Correctly pass on the dataset (#2651) MWPW-155289: Fixed filtering and sorting in catalog sidenav (#2653) handled empty hash case in deeplink MWPW-154124: use preview index (#2654) * MWPW-154124: use preview index * should remove both links [AUTOMATED-PR] Update imslib.min.js dependency (#2659) Update self hosted dependency Co-authored-by: GitHub Action <action@github.com> [MWPW-152181] Tabbing gets "stuck" after second instance of merch-card CTAs, within a segment blade (#2650) * Allow the default tab action to proceed if the current focused element is from the last merch card * ran "npm run build" * Updated readme * fix vulnerability * Revert "fix vulnerability" This reverts commit e34d131. * allow tabbing across section for merch cards --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> [MWPW-145131] Send locale and language code to analytics (#2670) MWPW-147867 - [marquee] support RTL for loc - RePost (#2676) added `support-rtl` selectors MWPW-155691 [MILO][MEP] Also use region in placeholders decision (#2680) * use region for placeholders * move region to it's own line * move value to last and add other MWPW-154901 Set debug=true on categories container (#2624) * MWPW-154901: enables debug=true based on container type * Update libs/blocks/caas/utils.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> [MWPW-136406] Tabs block enhancement: deep linking (#2652) * query param for focused tab * addressed feedback add lockup support lockup improvements updating button defaults fix button size logic update default btn size for banners MWPW-154981: adds a new Created Date option to details text (#2685) Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> MWPW-155781 [MILO] Geo Modal Tracking on BACOM - Missing custom link (#2694) add analytic MWPW-154898 No wait for modal fragment (#2607) No wait for modal fragment MWPW-154191: Ability to have green promo text on merch-card to bottom of the card (under description) (#2663) added promo-text slot to all merch cards MWPW-155654 Open TWP modal with preselected tab (#2691) * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab * Trigger Build * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab * MWPW-155654 Open TWP modal with preselected tab --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com> MWPW-154893 - [editorial-card] bugs (#2656) * added .support-rtl variant for easier rtl loc support * moved support-rtl to tablet up selector * remove right * removed margin-top bottom tablet styles * added empty class and updated has-footer to equal-height to expose that as a variant * s spacing gap default * action column-gap * no footer test coverage * PR feedback * revert marquee changes * updated .footer class to .card-footer to prevent naming colision * updated test ref * linting whitespace, test label clarity * revert icon block changes derp ENB-6995 Query Params update & sendTargetResponse function update Resubmit for #2664 (#2682) * Query Parms update & sendTargetResponse function update (#2664) * Query Parms update & sendTargetResponse function update - sendTargetResponse: Added Check for window._satellite and changed direct alloy call to _satellite call - Added additional parameter as marketingtech to disable analytics calls * Query Parms update & sendTargetResponse function update - Updated conditional chaining --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> * Update martech.js * not caching values --------- Co-authored-by: theankit-sinha <ankitsinha@adobe.com> Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> MWPW-153810 media image is seen loaded twice in product page urls in desktop (#2647) * placeholderChanges * placeholderChanges * Update utils.js * Update utils.js * Update utils.js * lint errors * Update utils.js * Update utils.js * Adding promise.all * Update utils.js * Update utils.js --------- Co-authored-by: Suhani <suhjain@suhanis-mbp.corp.adobe.com> [MWPW-155627] Merch Callout feature: Missing font cascade (#2679) add fallback to "Adobe Clean" font for callout text Co-authored-by: Rohit Sahu <rosahu@adobe.com> MWPW-153955 [PEP ] dismiss tool tip text is seen chopped in RTL locale in ipad and iphone in landscape mode (#2687) * Fixed pep dismissal tooltip in rtl locales * Update libs/features/webapp-prompt/webapp-prompt.css Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> --------- Co-authored-by: Rares Munteanu <overmyheadandbody@gmail.com> MWPW-154969 Log LCP and key user attributes (#2686) * MWPW-154969 Log LCP and key user attributes This adds the ability to log performance data back to Lana. To enable the feature, metadata `pageperf = ‘on’ ` must be set for the page. This feature only works in Chrome browsers. Additionally `pageperf-rate` can be set to determine what percentage of pages will send data. E.g `pageperf-rate=15` would have 15% of the pages send perf data. The default rate is `50`%. The sending of the data to Lana is delayed so as to not affect any parts of the page load. Data sent: * Chrome Version * CLS Score * Country (only if georouting is enabled via geo2) * Downlink: Mbps - Chrome caps value at `10` * LCP Score * LCP Element Type * LCP URL * If there is no identifying url, the element html will be used. * Adobe IMS Logged In Status * OS * URL of page * Window Width & Height * MEP Manifest Data * Manifest(s) Used (only the ones that have been applied to the page) * Selected Target in the manifest * Update logWebVitalsUtils.test.js * Address PR feedback --------- Co-authored-by: Okan Sahin <osahin@adobe.com> [MWPW-150579] Update supported browser list (#2696) MWPW-152952 Allow message for Marketo form success (#2545) MWPW-146237: Repurpose seotech-structured-data feature for arbitrary JSON-LD (#2578) * Add necessary helper functions * Fix two checks * Replace getStructuredData * Move things around * Fix regex? * Add env * Support localhost * Update paths * Fix test * Use seotech api instead * Update env/subdomain * Fix test properly * Update endoint * Add homepage * Update README * Rework endpoint handling * Add class to script tags * More doc updates revert PR of placeholder function as placeholder value is seen displayed with additional nbsp text in locale product pages in stage (#2709) Update utils.js Standalone GNav for Non-Milo Consumers (#2669) * Adding configuration for header component * Adding test cases * Adding css changes * Updated for css * Setting the origin to federal * Removing promise array * Adding redirect uri in meta * Updating meta insert function * Lint fix * Making error message descriptive --------- Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local> Making new GNAV experience default (#2689) Fix: Load gnav search files only if it is authored (#2700) [MWPW-154102] Accordion RTL alignment (#2704) [MWPW-156163] Send additional Slack notifications for high impact PRs (#2713) MWPW-156388 [MILO][MEP] fix for martech=off when page has manifest with enablements (#2720) * initial fix * Update libs/features/personalization/personalization.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * move where martech=off is used * move logic to handleEntitlements function --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> MWPW-156220: Support pa code and product code for (#2712) * MWPW-156220: Support pa code and product code for checkout link configuration in addition to product family. * optimize perf * PR feedback * PR feedback Added download and open-in spectrum icons (#2595) adde download and open-in spectrum icons Co-authored-by: Dragana Trajkovic <dragana.trajkovic@lilly021.com> MWPW-142166 One Page Gated (#2673) * MWPW-142166 One Page Gated * PR Changes MWPW-153987 [MILO][MEP] looks in wrong location for MEP test block code on stage (#2693) * calculate even on stage, find miloLibs and origin outside of loop * MWPW-155314 [MEP] Enable Entitlements + Operator (#2638) port over fixes --------- Co-authored-by: Jingle Huang <32369333+JingleH@users.noreply.github.com> [MWPW-154969] Performance consent (#2714) * Require consent * Improve the check * Apply suggestions from code review Co-authored-by: Narcis Radu <github@narcisradu.ro> * Fix linting issues * Fix linting and unit tests * Return faster * Track once consent is given * Fix unit tests * Remove defaults * Only listen to privacy once. --------- Co-authored-by: Narcis Radu <github@narcisradu.ro>

ryanmparrish added 8 commits July 26, 2024 16:49

added .support-rtl variant for easier rtl loc support

278be08

moved support-rtl to tablet up selector

4e6bb7a

remove right

8ff90c6

removed margin-top bottom tablet styles

c21a38a

added empty class and updated has-footer to equal-height to expose th…

b073e7f

…at as a variant

s spacing gap default

961546b

action column-gap

9a8260f

no footer test coverage

b7f8db4

ryanmparrish added the needs-verification PR requires E2E testing by a reviewer label Jul 30, 2024

ryanmparrish requested a review from a team July 30, 2024 18:03

ryanmparrish requested review from Sartxi and auniverseaway as code owners July 30, 2024 18:03

overmyheadandbody reviewed Jul 31, 2024

View reviewed changes

PR feedback

c7a5396

aem-code-sync bot temporarily deployed to rparrish/editorial-bugs July 31, 2024 17:01 Inactive

revert marquee changes

3112aba

aem-code-sync bot temporarily deployed to rparrish/editorial-bugs July 31, 2024 17:02 Inactive

updated .footer class to .card-footer to prevent naming colision

4342078

aem-code-sync bot temporarily deployed to rparrish/editorial-bugs July 31, 2024 21:42 Inactive

updated test ref

f3d361e

aem-code-sync bot temporarily deployed to rparrish/editorial-bugs July 31, 2024 21:51 Inactive

overmyheadandbody reviewed Aug 2, 2024

View reviewed changes

libs/blocks/editorial-card/editorial-card.css Outdated Show resolved Hide resolved

test/blocks/editorial-card/mocks/body.html Outdated Show resolved Hide resolved

mokimo approved these changes Aug 2, 2024

View reviewed changes

linting whitespace, test label clarity

89f66c4

ryanmparrish requested a review from elan-tbx as a code owner August 2, 2024 18:06

revert icon block changes derp

4ce6d12

aem-code-sync bot deployed to rparrish/editorial-bugs August 2, 2024 18:10 View deployment

overmyheadandbody approved these changes Aug 6, 2024

View reviewed changes

NadiiaSokolova approved these changes Aug 6, 2024

View reviewed changes

NadiiaSokolova added the Ready for Stage label Aug 6, 2024

robert-bogos approved these changes Aug 6, 2024

View reviewed changes

mokimo merged commit 8126603 into stage Aug 6, 2024
15 of 16 checks passed

mokimo deleted the rparrish/editorial-bugs branch August 6, 2024 16:57

mokimo mentioned this pull request Aug 6, 2024

[Release] Stage to Main #2697

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-154893 - [editorial-card] bugs #2656

MWPW-154893 - [editorial-card] bugs #2656

ryanmparrish commented Jul 30, 2024 •

edited

Loading

aem-code-sync bot commented Jul 30, 2024 •

edited

Loading

aem-code-sync bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

ryanmparrish commented Jul 31, 2024

overmyheadandbody left a comment

ryanmparrish commented Aug 2, 2024

overmyheadandbody left a comment

NadiiaSokolova left a comment

robert-bogos left a comment

robert-bogos Aug 6, 2024 •

edited

Loading

milo-pr-merge bot commented Aug 6, 2024

		const footer = editorialCards[3].querySelector('.card-footer');
		expect(footer).to.exist;

	const footer = editorialCards[3].querySelector('.card-footer');
	expect(footer).to.exist;
	expect(editorialCards[3].querySelector('.card-footer')).to.exist;

MWPW-154893 - [editorial-card] bugs #2656

MWPW-154893 - [editorial-card] bugs #2656

Conversation

ryanmparrish commented Jul 30, 2024 • edited Loading

aem-code-sync bot commented Jul 30, 2024 • edited Loading

aem-code-sync bot commented Jul 30, 2024 • edited Loading

codecov bot commented Jul 30, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 31, 2024

ryanmparrish commented Jul 31, 2024

overmyheadandbody left a comment

Choose a reason for hiding this comment

ryanmparrish commented Aug 2, 2024

overmyheadandbody left a comment

Choose a reason for hiding this comment

NadiiaSokolova left a comment

Choose a reason for hiding this comment

robert-bogos left a comment

Choose a reason for hiding this comment

robert-bogos Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

milo-pr-merge bot commented Aug 6, 2024

ryanmparrish commented Jul 30, 2024 •

edited

Loading

aem-code-sync bot commented Jul 30, 2024 •

edited

Loading

aem-code-sync bot commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading

robert-bogos Aug 6, 2024 •

edited

Loading