MWPW-156672: refactor commerce & optimize pandora dependencies #2723
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2723 +/- ##
==========================================
- Coverage 95.90% 95.89% -0.02%
==========================================
Files 173 173
Lines 45842 45842
==========================================
- Hits 43967 43958 -9
- Misses 1875 1884 +9 ☔ View full report in Codecov by Sentry. |
|
todo: test on adobe-students |
from business.adobe.com most likely browser will initiate a preflight, since its a different domain, but without testing I can't say for sure. |
| let wcsURL = 'https://www.adobe.com/web_commerce_artifact'; | ||
| if (lowHostEnv) { | ||
| wcsURL = 'https://www.stage.adobe.com/web_commerce_artifact'; |
There was a problem hiding this comment.
Nit: maybe string repetition could be avoided by determining the environment and then using a template literal to form the URL? Or maybe even a simple replace?
|
FYI tested adobe-students domain and it will keep working fine with CDN change. However I agree with Ilyas, it feels also too risky to me and we can't afford even a small CSO with this. |
|
smaller PR: #2725 |
|
Reminder to set the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
added some changes on this PR so will need a re-review:
|
| "@pandora/react-auth-provider": "file:./internal/react-auth-provider-1.2.1.tgz", | ||
| "@pandora/react-env-provider": "file:./internal/react-env-provider-1.2.2.tgz", | ||
| "@pandora/react-fetch-provider": "file:./internal/react-fetch-provider-1.2.2.tgz" | ||
| "@pandora/logger": "file:./internal/logger-1.3.0.tgz" |
There was a problem hiding this comment.
we should not depend on this anymore.
Did you try removing package-lock.json and npm install againg?
There was a problem hiding this comment.
yes, the checkout builder is pulling the data source package, which pulls logger etc
| @@ -5,12 +5,6 @@ import { | |||
| buildCheckoutUrl, | |||
| } from '@pandora/commerce-checkout-url-builder'; | |||
| import { Term, Commitment } from '@pandora/data-models-odm'; | |||
There was a problem hiding this comment.
we don't need these imports/we can replace them, I propose to remove them as well.
| /** | ||
| * Cache of promises resolving to arrays of Wcs offers grouped by osi-based keys. | ||
| * @type {Map<string, Promise<Commerce.Wcs.Offer[]>>} | ||
| */ | ||
| const cache = new Map(); | ||
| /** | ||
| * Queue of pending requests to Wcs grouped by locale and promo. | ||
| * @type {Map<string, { options: WcsOptions, promises: WcsPromises }>} |
There was a problem hiding this comment.
We could define WcsOptions here in this file as well.
This PR is a follow up of #2725 and:
Resolves: https://jira.corp.adobe.com/browse/MWPW-156672
Original discussion: https://git.corp.adobe.com/orgs/wcms/discussions/38
Test URLs: