Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-152283: Commerce endpoint update #2725

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

3ch023
Copy link
Contributor

@3ch023 3ch023 commented Aug 12, 2024

Switching WCS commerce requests endpoints from wcs.adobe.com to abobe.com.
No actions for consumers, except extra caution & regression testing of how Prices/CTAs are renderred on your pages.

Resolves: https://jira.corp.adobe.com/browse/MWPW-152283

In the previous PR, we decided it's too risky to ship big refactoring AND a CDN endpoint update for commerce.
So I created this minimal PR just updating endpoints and no refactoring.
The second PR with refactored code:
#2723

Test URLs:

@3ch023 3ch023 added run-nala Run Nala Test Automation against PR commerce labels Aug 12, 2024
@3ch023 3ch023 requested a review from a team as a code owner August 12, 2024 16:22
Copy link
Contributor

aem-code-sync bot commented Aug 12, 2024

Page Scores Audits Google
/drafts/mariia/pr/price-cta?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (60cb005) to head (f32f491).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2725   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         173      173           
  Lines       45733    45733           
=======================================
+ Hits        43791    43792    +1     
+ Misses       1942     1941    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@3ch023 3ch023 requested a review from Roycethan August 13, 2024 07:09
@afmicka
Copy link
Contributor

afmicka commented Aug 13, 2024

@3ch023 I see following issues on your branch, could you please check?

  1. pages with promotion/personalization are not loading on your branch?
    https://killwcsp1--milo--3ch023.hlx.live/drafts/nala/features/promotions/promo-insert

  2. OST version is either broken or old. The merch links are generated with all the parameters (term, tax, old etc.) while on main those are removed some time ago. Also there is Optical price for the offer that should not have it. See the screenshots.
    word test: https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7B3d9aeab6-1f46-4571-b18f-af6be8e8213c%7D&action=editnew

main: Screenshot 2024-08-13 at 14 51 33
kill wcs: Screenshot 2024-08-13 at 14 51 25
main: Screenshot 2024-08-13 at 14 51 11
kill wcs: Screenshot 2024-08-13 at 14 51 04

@3ch023
Copy link
Contributor Author

3ch023 commented Aug 13, 2024

Hi @afmicka I fixed both issue by refreshing the code in my fork..
could you please check again?
image

@3ch023 3ch023 added the high-impact Any PR that may affect consumers label Aug 13, 2024
@3ch023 3ch023 changed the title endpoint update MWPW-152283: Commerce endpoint update Aug 13, 2024
@afmicka
Copy link
Contributor

afmicka commented Aug 13, 2024

lgtm

@afmicka afmicka added verified PR has been E2E tested by a reviewer Ready for Stage labels Aug 13, 2024
@milo-pr-merge milo-pr-merge bot merged commit d6b7e33 into adobecom:stage Aug 13, 2024
30 of 32 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high-impact Any PR that may affect consumers Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants