-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-152283: Commerce endpoint update #2725
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2725 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 45733 45733
=======================================
+ Hits 43791 43792 +1
+ Misses 1942 1941 -1 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
@3ch023 I see following issues on your branch, could you please check?
|
Hi @afmicka I fixed both issue by refreshing the code in my fork.. |
lgtm |
Switching WCS commerce requests endpoints from wcs.adobe.com to abobe.com.
No actions for consumers, except extra caution & regression testing of how Prices/CTAs are renderred on your pages.
Resolves: https://jira.corp.adobe.com/browse/MWPW-152283
In the previous PR, we decided it's too risky to ship big refactoring AND a CDN endpoint update for commerce.
So I created this minimal PR just updating endpoints and no refactoring.
The second PR with refactored code:
#2723
Test URLs: