Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157761: Tab preselect in external modals [catalog] #2828

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Axelcureno
Copy link
Member

Fixes preselected tab not working in external modals (Twp) on Catalog page.

Resolves: MWPW-157761

Test URLs:

@Axelcureno Axelcureno added run-nala Run Nala Test Automation against PR commerce high priority Why is this a high priority? Blocker? Critical? Dependency? labels Sep 4, 2024
@Axelcureno Axelcureno requested a review from a team as a code owner September 4, 2024 18:18
Copy link
Contributor

aem-code-sync bot commented Sep 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (501f559) to head (2978454).
Report is 2 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2828      +/-   ##
==========================================
- Coverage   95.88%   95.88%   -0.01%     
==========================================
  Files         173      173              
  Lines       46300    46303       +3     
==========================================
+ Hits        44396    44397       +1     
- Misses       1904     1906       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3ch023 3ch023 removed the run-nala Run Nala Test Automation against PR label Sep 4, 2024
@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 4, 2024
@milo-pr-merge milo-pr-merge bot merged commit 8956fbe into stage Sep 4, 2024
29 of 33 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-157761 branch September 4, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants