MWPW-157864 [Catalog] Localise external modals #3277
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3277 +/- ##
=======================================
Coverage 96.43% 96.44%
=======================================
Files 253 253
Lines 58761 58769 +8
=======================================
+ Hits 56669 56680 +11
+ Misses 2092 2089 -3 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -529,7 +537,7 @@ export async function getModalAction(offers, options, el) { | |||
| const hash = setCtaHash(el, checkoutLinkConfig, offerType); | |||
| let url = checkoutLinkConfig[columnName]; | |||
| if (!url) return undefined; | |||
| url = isInternalModal(url) | |||
| url = isInternalModal(url) || isProdModal(url) | |||
There was a problem hiding this comment.
not your code but i would rather go with
url = isInternalModal(url) || isProdModal(url) ? localizeLink(url) : url
or
if (isInternalModal(url) || isProdModal(url)) url =localizeLink(url);
* MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * MWPW-157864 [Catalog] Localise external modals * Trigger Build --------- Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Bringing back localization for modal URLs after #2828
Resolves: MWPW-157864
Test URLs: