Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3355

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[Release] Stage to Main #3355

wants to merge 11 commits into from

Conversation

vgoodric and others added 4 commits December 11, 2024 09:17
* initial publish

* first commit

* cleaned up

* fixed id dupes

* tighten up accordion height, increase width

* Add source

* Remove shown

* Fix freshManifest source

* committing better version not neat

* added divs to dropdowns

* stab at data parse for db

* refine parseMepConfig

* align to db, improve form look, add event listeners

* stop using block name constant

* update to aws api

* Unfinished code for Viv

* Fix undefined manifest

* Add back properties and fix small DOM issue

* Add get getMepPopup

* stash

* save working

* Confine listeners to current meplist

* add url param and hash method for sharing

* just omit promos out of date range

* minor fixes and checks

* add condition for mepHighlight

* pulling in manifest info

* don't show arrow on mep panel in mmm

* refactor functions

* Fix radio and preview buttons

* Remove comment

* Fix typo

* rework share logic fix spacing color

* fix merge conflict bug

* fix merge conflict created bug

* Add another pageId

* Fix label click issue

* Fix pencil issue

* bunch of fixes

* deep link

* add conditional chaining

* refactor and streamline

* update now that pathname is sent by db

* fix page search for new db structure

* switch to full field name not first letter

* change all to empty

* top geos and top pages

* remove line

* fix breaking from merge

* loops through filters instead of hard code

* keep share button on right in mobile

* no longer using form.html

* default all doesn't need to be in Word

* share button on top

* create shareButton listeners at creation

* rename functions

* remove unneeded files

* restore fix to update button

* change served to found

* add change listener to input

* unit tests working

* button back but not visible

* button fixed

* add sharebutton unit test

* fix share button test

* repair existing unit tests

* update mmm test after other fixes

* collapse all when new one opened

* update to new db column names

* fix issue with preview link including entire manifest url instead of just path

* fix activites filter in saveToMmm

* add source for mep param, fix filter for save

* fix radio buttons to only use path

* duplicate schedule info

* mmmremovemepsource

* fix page save and analyticsTitle

* tweak placeholder helpful info

* Fix code scanning alert no. 235: Incomplete URL substring sanitization

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* remove unused

* tweak to suggested security fix

* unit test update

* curious what the security check says

* revert

* remove authorization

* lint issue

* simplify milo check

* add source to default promo shell... again

* update css rule for add manifest input

* hide scheduled info in mmm

* remove unused import and return error message

---------

Co-authored-by: viloria <viloria@adobe.com>
Co-authored-by: markpadbe <markp@adobe.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…fix (#3318)

* Adding dynamic-nav-group setting to allow distinction between dynamic-nav user journeys

* Utils change

* Ensuring status shows correctly dispite group

* Making metadata case insensative

* Does a check for status.js if storage item does not exist

---------

Co-authored-by: Megan Thomas <methomas@adobe.com>
* cta color hover change

* cta color hover change

* cta color hover change

---------

Co-authored-by: Suhani <suhjain@suhanis-mbp.corp.adobe.com>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Dec 11, 2024

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 99.48365% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.48%. Comparing base (4e29c5c) to head (d543279).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libs/features/personalization/preview.js 99.17% 2 Missing ⚠️
.../features/dynamic-navigation/dynamic-navigation.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
+ Coverage   96.43%   96.48%   +0.04%     
==========================================
  Files         253      254       +1     
  Lines       58761    59031     +270     
==========================================
+ Hits        56669    56954     +285     
+ Misses       2092     2077      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* MWPW-157864 [Catalog] Localise external modals

* MWPW-157864 [Catalog] Localise external modals

* MWPW-157864 [Catalog] Localise external modals

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner December 11, 2024 11:05
…nd individual SVG assets" (#3356)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and indiv…"

This reverts commit 81a5770.
* Adding video fill variant

* PR feedback, css clean up

* Fixing code conflicts with #3053

---------

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* Adds marketo forms2.min.js to dependencies, upates dependency workflow, updates marketo.js to call form from correct location

* Adding comment for git change only

* Adding comment to hopefully see change

* Removing comments

* Typo

* Updating PR description

* Fixing tests
Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Dec 24, 2024
@github-actions github-actions bot removed the Stale label Dec 25, 2024
@mokimo mokimo deployed to milo_pr_merge December 27, 2024 08:13 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.