Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets" #3356

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mokimo
Copy link
Contributor

@mokimo mokimo commented Dec 11, 2024

Reverts #3259 due to missing consumer icons and 404s on production for other use-cases such as project unity.

@mokimo mokimo requested a review from ryanmparrish as a code owner December 11, 2024 11:40
Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (b49d012) to head (2e30b49).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3356      +/-   ##
==========================================
- Coverage   96.48%   96.48%   -0.01%     
==========================================
  Files         254      254              
  Lines       59118    59029      -89     
==========================================
- Hits        57042    56953      -89     
  Misses       2076     2076              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

aem-code-sync bot commented Dec 11, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aishwaryamathuria aishwaryamathuria self-requested a review December 11, 2024 11:55
@SilviuLCF SilviuLCF self-requested a review December 11, 2024 12:00
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verifeid

@mokimo mokimo merged commit 0052f31 into stage Dec 11, 2024
20 checks passed
@mokimo mokimo deleted the revert-3259-rparrish/fed-icons branch December 11, 2024 12:07
nishantka pushed a commit to nishantka/milo that referenced this pull request Dec 13, 2024
…nd individual SVG assets" (adobecom#3356)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and indiv…"

This reverts commit 81a5770.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants