-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets #3259
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3259 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 245 245
Lines 56746 56835 +89
=======================================
+ Hits 54698 54787 +89
Misses 2048 2048 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
…o be sharepoint authorable
…e condition w/ decorateIcon()
…Preloaded inView icons and defered others till postSectionLoad.
* reselect icons after area is decorated * fix inline margin issue in table collapse titles
77b2a12
to
d31368a
Compare
Rebased with current |
Skipped 3259: "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets" due to file "libs/blocks/table/table.css" overlap. Merging will be attempted in the next batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified
Skipped 3259: "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
This initial PR was reverted due to some issues found w/ tooltips in the table block. re-submitting as this has been resolved.
To streamline icon management across Milo and other consuming sites, a centralized repository, federal, along with a directory named
icons/svgs
, will be established. This will provide shared access to a unified set of icons. The transition will maintain the current authoring experience, while also introducing new opportunities for contributors to expand the icon set. The key points of this change are outlined below:Key Points:
Centralized Icon Repository: A new /assets/icons/svgs directory was added to the /federal/ repo, allowing multiple sites (Milo and others) to use the same set of icons. All icons currently available are listed here /icons/icons.json
Consistent Authoring Notation: Authors will continue to use the current notation, such as
:icon-play:
, to insert icons into content. This ensures a seamless transition with no change in authoring experience.Source Change: Icons will no longer be served from the Milo code-bus. Instead, they will be fetched from the federal repository via the content-bus.
Author Contributions: This new system enables authors to contribute and expand the icon set by adding new icons to the centralized repository, a feature that was previously unavailable.
Subsequent Ticket: The Sidekick plugin library will be updated in a subsequent ticket to improve authoring accessibility for that component - see MWPW-159581
Resolves: MWPW-140452
Draft URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/icon/icons-federal?martech=off
After: https://rparrish-fed-icons--milo--adobecom.hlx.page/drafts/rparrish/icon/icons-federal?martech=off
Doc URLs:
Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/?martech=off
After: https://rparrish-fed-icons--milo--adobecom.hlx.page/docs/library/kitchen-sink/?martech=off
URLs where the
tooltip / table
issue was found:https://main--dc--adobecom.hlx.page/acrobat/pricing?milolibs=rparrish-fed-icons&martech=off
https://main--bacom--adobecom.hlx.page/?milolibs=rparrish-fed-icons